Rename ext method to StripDbQuotes to avoid conflicts with SS.Text

Author: mythz

src/ServiceStack.OrmLite.MySql/MySqlDialectProviderBase.cs

@@ -417,7 +417,7 @@ public override string ToTableNamesWithRowCountsStatement(bool live, string sche
         public override bool DoesTableExist(IDbCommand dbCmd, string tableName, string schema = null)
         {
             var sql = "SELECT COUNT(*) FROM INFORMATION_SCHEMA.TABLES WHERE TABLE_NAME = {0} AND TABLE_SCHEMA = {1}"
-                .SqlFmt(GetTableName(tableName, schema).StripQuotes(), dbCmd.Connection.Database);
+                .SqlFmt(GetTableName(tableName, schema).StripDbQuotes(), dbCmd.Connection.Database);
 
             var result = dbCmd.ExecLongScalar(sql);
 
@@ -429,7 +429,7 @@ public override bool DoesColumnExist(IDbConnection db, string columnName, string
             tableName = GetTableName(tableName, schema);
             var sql = "SELECT COUNT(*) FROM INFORMATION_SCHEMA.COLUMNS"
                       + " WHERE TABLE_NAME = @tableName AND COLUMN_NAME = @columnName AND TABLE_SCHEMA = @schema"
-                          .SqlFmt(GetTableName(tableName, schema).StripQuotes(), columnName);
+                          .SqlFmt(GetTableName(tableName, schema).StripDbQuotes(), columnName);
 
             var result = db.SqlScalar<long>(sql, new { tableName, columnName, schema = db.Database });
 

src/ServiceStack.OrmLite/Expressions/SqlExpression.cs

@@ -2435,7 +2435,7 @@ protected string RemoveQuoteFromAlias(string exp)
         protected virtual bool IsFieldName(object quotedExp)
         {
             var fieldExpr = quotedExp.ToString().StripTablePrefixes();
-            var unquotedExpr = fieldExpr.StripQuotes();
+            var unquotedExpr = fieldExpr.StripDbQuotes();
 
             var isTableField = modelDef.FieldDefinitionsArray
                 .Any(x => GetColumnName(x.FieldName) == unquotedExpr);

src/ServiceStack.OrmLite/OrmLiteDialectProviderBase.cs

@@ -1329,7 +1329,7 @@ public virtual string ToCreateTableStatement(Type tableType)
         public virtual string GetUniqueConstraints(ModelDefinition modelDef)
         {
             var constraints = modelDef.UniqueConstraints.Map(x => 
-                $"CONSTRAINT {GetUniqueConstraintName(x, GetTableName(modelDef).StripQuotes())} UNIQUE ({x.FieldNames.Map(f => modelDef.GetQuotedName(f,this)).Join(",")})" );
+                $"CONSTRAINT {GetUniqueConstraintName(x, GetTableName(modelDef).StripDbQuotes())} UNIQUE ({x.FieldNames.Map(f => modelDef.GetQuotedName(f,this)).Join(",")})" );
 
             return constraints.Count > 0
                 ? constraints.Join(",\n")

src/ServiceStack.OrmLite/OrmLiteUtils.cs

@@ -818,9 +818,9 @@ public static string StripTablePrefixes(this string selectExpression)
             return StringBuilderCache.ReturnAndFree(sb).Trim();
         }
 
-        public static char[] QuotedChars = new[] { '"', '`', '[', ']' };
+        public static char[] QuotedChars = { '"', '`', '[', ']' };
 
-        public static string StripQuotes(this string quotedExpr)
+        public static string StripDbQuotes(this string quotedExpr)
         {
             return quotedExpr.Trim(QuotedChars);
         }
@@ -1117,6 +1117,6 @@ public static string QuotedLiteral(string text) => text == null || text.IndexOf(
             ? text
             : "'" + text + "'";
 
-        public static string UnquotedColumnName(string columnExpr) => columnExpr.LastRightPart('.').StripQuotes();
+        public static string UnquotedColumnName(string columnExpr) => columnExpr.LastRightPart('.').StripDbQuotes();
     }
 }

src/ServiceStack.OrmLite/OrmLiteWriteCommandExtensions.cs

@@ -743,7 +743,7 @@ internal static IDbCommand InsertIntoSelectInternal<T>(this IDbCommand dbCmd, IS
                 .ParseCommands();
 
             var fieldsOrAliases = selectFields
-                .Map(x => x.Original.ToString().LastRightPart(" AS ").Trim().StripQuotes());
+                .Map(x => x.Original.ToString().LastRightPart(" AS ").Trim().StripDbQuotes());
 
             dialectProvider.PrepareParameterizedInsertStatement<T>(dbCmd, insertFields: fieldsOrAliases);
 

tests/ServiceStack.OrmLite.Tests/MetaDataTests.cs

@@ -143,7 +143,7 @@ public void Can_get_GetTableNamesWithRowCounts_of_keyword_table()
                 var tableNames = db.GetTableNamesWithRowCounts(live:true);
                 Assert.That(tableNames.Count, Is.GreaterThan(0));
 
-                var table1Name = db.GetDialectProvider().GetTableName(typeof(Order).GetModelMetadata()).StripQuotes();
+                var table1Name = db.GetDialectProvider().GetTableName(typeof(Order).GetModelMetadata()).StripDbQuotes();
 
                 var table1Pos = IndexOf(tableNames, x => x.Key.EqualsIgnoreCase(table1Name) && x.Value == 3);
                 Assert.That(table1Pos, Is.GreaterThanOrEqualTo(0));
@@ -201,8 +201,8 @@ public void Can_get_GetTableNamesWithRowCounts_in_Schema()
                 tableNames.TextDump().Print();
                 Assert.That(tableNames.Count, Is.GreaterThan(0));
 
-                var table1Name = db.GetDialectProvider().GetTableName(typeof(Schematable1).GetModelMetadata()).LastRightPart('.').StripQuotes();
-                var table2Name = db.GetDialectProvider().GetTableName(typeof(Schematable2).GetModelMetadata()).LastRightPart('.').StripQuotes();
+                var table1Name = db.GetDialectProvider().GetTableName(typeof(Schematable1).GetModelMetadata()).LastRightPart('.').StripDbQuotes();
+                var table2Name = db.GetDialectProvider().GetTableName(typeof(Schematable2).GetModelMetadata()).LastRightPart('.').StripDbQuotes();
 
                 var table1Pos = IndexOf(tableNames, x => x.Key.IndexOf(table1Name, StringComparison.OrdinalIgnoreCase) >=0 && x.Value == 3);
                 Assert.That(table1Pos, Is.GreaterThanOrEqualTo(0));

tests/ServiceStack.OrmLite.Tests/TemplateDbTests.cs

@@ -39,7 +39,7 @@ public async Task Can_call_dbSingle_with_param()
                 db.DropAndCreateTable<Rockstar>();
                 db.InsertAll(AutoQueryTests.SeedRockstars);
 
-                var firstName = "FirstName".SqlColumn(DialectProvider).StripQuotes();
+                var firstName = "FirstName".SqlColumn(DialectProvider).StripDbQuotes();
 
                 var args = new Dictionary<string, object> { { "id", 3 }};