Skip to content

Commit 96a4b64

Browse files
committed
Update fbq generator to recommended settings from Meta
1 parent 9aa21bf commit 96a4b64

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

src/Generator/FbqGenerator.php

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -9,7 +9,7 @@
99

1010
final class FbqGenerator implements FbqGeneratorInterface
1111
{
12-
public function generateInit(Event $event, bool $includeScriptTag = false): string
12+
public function generateInit(Event $event, bool $includePageView = true, bool $includeScriptTag = false): string
1313
{
1414
$json = json_encode($event->userData->getPayload(Parameters::PAYLOAD_CONTEXT_BROWSER), \JSON_THROW_ON_ERROR);
1515

@@ -19,6 +19,10 @@ public function generateInit(Event $event, bool $includeScriptTag = false): stri
1919
$str .= sprintf("fbq('init', '%s', %s);", $pixel->id, $json);
2020
}
2121

22+
if ($includePageView) {
23+
$str .= "fbq('track', 'PageView');";
24+
}
25+
2226
if ($includeScriptTag) {
2327
$str = sprintf('<script>%s</script>', $str);
2428
}

src/Generator/FbqGeneratorInterface.php

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,7 @@ interface FbqGeneratorInterface
1111
/**
1212
* Will generate the fbq() init call based on the given event and for each pixel ids defined in the event
1313
*/
14-
public function generateInit(Event $event, bool $includeScriptTag = false): string;
14+
public function generateInit(Event $event, bool $includePageView = true, bool $includeScriptTag = false): string;
1515

1616
/**
1717
* Will generate the fbq() tracking call based on the given event and for each pixel ids defined in the event

tests/Generator/FbqGeneratorTest.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -25,14 +25,14 @@ public function it_generates_init(): void
2525

2626
$generator = new FbqGenerator();
2727
self::assertSame(<<<EXPECTED
28-
fbq('init', '111', {"db":["cccd631dbe89ae6c982a960f248fabab8a4ae7f899853a3ea5bceef8ca1d6585"]});fbq('init', '222', {"db":["cccd631dbe89ae6c982a960f248fabab8a4ae7f899853a3ea5bceef8ca1d6585"]});
28+
fbq('init', '111', {"db":["cccd631dbe89ae6c982a960f248fabab8a4ae7f899853a3ea5bceef8ca1d6585"]});fbq('init', '222', {"db":["cccd631dbe89ae6c982a960f248fabab8a4ae7f899853a3ea5bceef8ca1d6585"]});fbq('track', 'PageView');
2929
EXPECTED
3030
, $generator->generateInit($event));
3131

3232
self::assertSame(<<<EXPECTED
33-
<script>fbq('init', '111', {"db":["cccd631dbe89ae6c982a960f248fabab8a4ae7f899853a3ea5bceef8ca1d6585"]});fbq('init', '222', {"db":["cccd631dbe89ae6c982a960f248fabab8a4ae7f899853a3ea5bceef8ca1d6585"]});</script>
33+
<script>fbq('init', '111', {"db":["cccd631dbe89ae6c982a960f248fabab8a4ae7f899853a3ea5bceef8ca1d6585"]});fbq('init', '222', {"db":["cccd631dbe89ae6c982a960f248fabab8a4ae7f899853a3ea5bceef8ca1d6585"]});fbq('track', 'PageView');</script>
3434
EXPECTED
35-
, $generator->generateInit($event, true));
35+
, $generator->generateInit($event, true, true));
3636
}
3737

3838
/**

0 commit comments

Comments
 (0)