Reflix project #1
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ameliawalcek
left a comment
ameliawalcek
left a comment
There was a problem hiding this comment.
really great job! Let me know if y9ou have any questions
| # production | ||
| /build | ||
|
|
||
| # misc |
There was a problem hiding this comment.
when you use a .env dont forget to add it here
| } | ||
| } | ||
|
|
||
| rentMovie = (movieID, result) =>{ |
There was a problem hiding this comment.
if you use somthing over and over, it would be best just to redefine it to make your code cleaner
const {users, currentUserID, catalog} = this.state
| rentMovie = (id, result ) =>{ | ||
| this.props.rentMovie(id, result) | ||
| } | ||
| handleSearch = (event) =>{ |
There was a problem hiding this comment.
can also write it like
handleSearch = ({target}) => this.setState({searchTerm: target.value})
|
|
||
|
|
||
| ReactDOM.render( | ||
| <React.StrictMode> |
There was a problem hiding this comment.
I would remove React.StrictMode. I can keep reloading your app and causing your problems.
ReactDOM.render(
<App />,
document.getElementById('root')
);
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.