slcc: conditions: fix misplaced condition #47
+2
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, the condition for including certain files was applied only to the file entry within a directory. This caused the directory itself to be included in build system paths even when the condition was not met, resulting in errors due to non-existent include paths. This commit moves the condition to the directory level, ensuring that both the directory and its files are only included when the condition is satisfied. This prevents the build system from referencing invalid paths and resolves related build issues. The same adjustment can be apply to other configuration files following this pattern.
|
This could be seen on standalone project where not all the sdk files are available. |
remi-vicente-sfy
approved these changes
Sep 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the condition for including certain files was applied only to the file entry within a directory. This caused the directory itself to be included in build system paths even when the condition was not met, resulting in errors due to non-existent include paths. This commit moves the condition to the directory level, ensuring that both the directory and its files are only included when the condition is satisfied. This prevents the build system from referencing invalid paths and resolves related build issues.
The same adjustment can be apply to other configuration files following this pattern.