Skip to content

Commit 2948376

Browse files
committed
Fix id typing
1 parent f97ebb9 commit 2948376

File tree

9 files changed

+9
-9
lines changed

9 files changed

+9
-9
lines changed

lib/models/directbilling/transaction/db.transaction.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { DbTransactionStatus } from './db.transaction.status';
22
import { DbProvider } from '../service/db.provider';
33
export interface DbTransaction {
4-
id: number;
4+
id: string;
55
status: DbTransactionStatus;
66
phoneNumber?: string;
77
control: string;

lib/models/directbilling/transaction/partial.db.transaction.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import { DbProvider } from '../service/db.provider';
22
import { DbTransactionStatus } from './db.transaction.status';
33
export interface PartialDbTransaction {
4-
id: number;
4+
id: string;
55
status: DbTransactionStatus;
66
value: number;
77
value_netto: number;

lib/payments/directbilling.d.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ export declare class DirectBilling {
1717
calculateCommission(serviceId: number, amount: number): Promise<DbCalculation | undefined>;
1818
getTransactions(serviceId: number): Promise<PartialDbTransaction[]>;
1919
getTransactionsPaginated(serviceId: number, page?: number, pageSize?: number): Promise<PaginatedResponse<PartialDbTransaction>>;
20-
getTransaction(serviceId: number, transactionId: number): Promise<DbTransaction | undefined>;
20+
getTransaction(serviceId: number, transactionId: string): Promise<DbTransaction | undefined>;
2121
createTransaction(serviceId: number, key: string, request: DbTransactionRequest): Promise<DbGenerationResponse | undefined>;
2222
checkNotification(key: string, body: any): DbTransaction | undefined;
2323
generateSignature(key: string, request: DbTransactionRequest): string;

lib/tests/directbilling.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -24,7 +24,7 @@ const run = () => __awaiter(void 0, void 0, void 0, function* () {
2424
console.log(yield db.getTransactions(158));
2525
console.log(yield db.getTransactionsPaginated(158, 1, 100));
2626
// https://docs-new.simpay.pl/typescript/?typescript#directbilling-pobieranie-informacji-o-transakcji
27-
console.log(yield db.getTransaction(158, 559911));
27+
console.log(yield db.getTransaction(158, '559911'));
2828
// https://docs-new.simpay.pl/typescript/?typescript#directbilling-generowanie-transakcji
2929
console.log(yield db.createTransaction(158, 'key', {
3030
amount: 10.00,

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
{
22
"name": "simpay-typescript-api",
33
"author": "Rafał Więcek",
4-
"version": "2.1.1",
4+
"version": "2.1.2",
55
"description": "SimPay.pl API",
66
"main": "lib/index.js",
77
"types": "lib/index.d.ts",

src/models/directbilling/transaction/db.transaction.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {DbTransactionStatus} from './db.transaction.status';
22
import {DbProvider} from '../service/db.provider';
33

44
export interface DbTransaction {
5-
id: number;
5+
id: string;
66
status: DbTransactionStatus;
77

88
phoneNumber?: string;

src/models/directbilling/transaction/partial.db.transaction.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import {DbProvider} from '../service/db.provider';
22
import {DbTransactionStatus} from './db.transaction.status';
33

44
export interface PartialDbTransaction {
5-
id: number;
5+
id: string;
66
status: DbTransactionStatus;
77

88
value: number;

src/payments/directbilling.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -138,7 +138,7 @@ export class DirectBilling {
138138
/*
139139
https://docs-new.simpay.pl/typescript/?typescript#directbilling-pobieranie-informacji-o-transakcji
140140
*/
141-
async getTransaction(serviceId: number, transactionId: number): Promise<DbTransaction | undefined> {
141+
async getTransaction(serviceId: number, transactionId: string): Promise<DbTransaction | undefined> {
142142
const transaction = (await this.client.get(`/${serviceId}/transactions/${transactionId}`)).data.data;
143143

144144
transaction.created_at = new Date(transaction.created_at.replace(' ', 'T'));

src/tests/directbilling.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@ const run = async () => {
1919
console.log( await db.getTransactionsPaginated(158, 1, 100) );
2020

2121
// https://docs-new.simpay.pl/typescript/?typescript#directbilling-pobieranie-informacji-o-transakcji
22-
console.log( await db.getTransaction(158, 559911) );
22+
console.log( await db.getTransaction(158, '559911') );
2323

2424
// https://docs-new.simpay.pl/typescript/?typescript#directbilling-generowanie-transakcji
2525
console.log( await db.createTransaction(158, 'key', {

0 commit comments

Comments
 (0)