fix: prevent duplicate elements in LaunchScreen.storyboard on repeated runs#81
Draft
fix: prevent duplicate elements in LaunchScreen.storyboard on repeated runs#81
Conversation
Co-authored-by: ujas-m-simformsolutions <76939001+ujas-m-simformsolutions@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix issue with duplicate entries in LaunchScreen.storyboard
fix: prevent duplicate constraints in LaunchScreen.storyboard on repeated runs
Dec 3, 2025
ujas-m-simformsolutions
requested changes
Dec 3, 2025
| <constraint firstAttribute="trailing" secondItem="YRO-k0-Ey4" secondAttribute="trailing" id="TQA-XW-tRk"/> | ||
| <constraint firstItem="YRO-k0-Ey4" firstAttribute="bottom" secondItem="Ze5-6b-2t3" secondAttribute="bottom" id="duK-uY-Gun"/> | ||
| <constraint firstAttribute="bottom" secondItem="edQ-YT-iED" secondAttribute="bottom" id="e2S-gZ-2jl"/> | ||
| <constraint firstAttribute="bottom" secondItem="edQ-YT-iED" secondAttribute="bottom" id="wnX-KJ-aN5"/> |
Collaborator
There was a problem hiding this comment.
dont remove this constraint
Contributor
Author
There was a problem hiding this comment.
Restored the constraint in commit d214e27.
Collaborator
There was a problem hiding this comment.
the command adds duplicate image with id edQ-YT-iED
Contributor
Author
There was a problem hiding this comment.
Fixed in commit d214e27. Added logic to check for existing background image element in the storyboard before creating a new one, preventing duplicates.
Co-authored-by: ujas-m-simformsolutions <76939001+ujas-m-simformsolutions@users.noreply.github.com>
Copilot
AI
changed the title
fix: prevent duplicate constraints in LaunchScreen.storyboard on repeated runs
fix: prevent duplicate elements in LaunchScreen.storyboard on repeated runs
Dec 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Running
dart run splash_master createmultiple times duplicated elements inLaunchScreen.storyboard, causing invalid XML that breaks iOS builds.Changes
Fix duplicate background image element (
lib/cmd/ios_splash.dart)edQ-YT-iEDbefore creating a new onegetBackgroundImageElement(subViews)to verify element doesn't exist before creationFix constraint cleanup logic (
lib/cmd/ios_splash.dart)remove(getElement())toremoveWhere()at lines 178-183 and 216-221This makes the command idempotent—multiple runs produce identical, valid output without duplicate elements.
Checklist
fix:,feat:,docs:etc).docsand added dartdoc comments with///.examplesordocs.Breaking Change?
Related Issues
Closes #80
Original prompt
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.