Skip to content

Conversation

@jorisv
Copy link

@jorisv jorisv commented May 26, 2025

Fix:

  • MSVC build
  • casadi build
  • cppadcg build

Change:

  • C++17 as C++ minimal version

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👋 Hi,
This is a reminder message to assign an extra build label to this Pull Request if needed.
By default, this PR will be build with minimal build options (URDF support and Python bindings)
The possible extra labels are:

  • build_collision (build Pinocchio with coal support)
  • build_casadi (build Pinocchio with CasADi support)
  • build_autodiff (build Pinocchio with CppAD support)
  • build_codegen (build Pinocchio with CppADCodeGen support)
  • build_extra (build Pinocchio with extra algorithms)
  • build_mpfr (build Pinocchio with Boost.Multiprecision support)
  • build_sdf (build Pinocchio with SDF parser)
  • build_accelerate (build Pinocchio with APPLE Accelerate framework support)
  • build_all (build Pinocchio with ALL the options stated above)

Thanks.
The Pinocchio development team.

@jorisv jorisv force-pushed the topic/fix-pin4-ci branch from f442f09 to d15e1d2 Compare May 26, 2025 15:50
@jorisv jorisv changed the title Fix MSVC cl build Fix build May 27, 2025

#ifdef PINOCCHIO_WITH_SDFORMAT

/*
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did you comment this?

@jorisv jorisv force-pushed the topic/fix-pin4-ci branch from dbe54a4 to 96b29fd Compare June 11, 2025 07:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants