Merge pull request #30 from jsoulier/main

romancardenas · web-flow · commit 64f61d96e729 · 2024-11-29T18:07:12.000+01:00
Fix floating point round error
diff --git a/include/cadmium/celldevs/grid/scenario.hpp b/include/cadmium/celldevs/grid/scenario.hpp
@@ -201,7 +201,7 @@ namespace cadmium::celldevs {
 				throw CadmiumModelException("p must be greater than 0");
 			}
 			auto x = std::accumulate(distance.begin(), distance.end(), 0., [p](double sum, int v) { return sum + std::pow(std::abs(v), p); });
-			return std::pow(x, 1 / p);
+			return std::pow(x, 1.0 / p);
 		}
 
 		/**

Original file line number	Diff line number	Diff line change
`@@ -201,7 +201,7 @@ namespace cadmium::celldevs {`
`201`	`201`	`throw CadmiumModelException("p must be greater than 0");`
`202`	`202`	`}`
`203`	`203`	`auto x = std::accumulate(distance.begin(), distance.end(), 0., [p](double sum, int v) { return sum + std::pow(std::abs(v), p); });`
`204`		`- return std::pow(x, 1 / p);`
	`204`	`+ return std::pow(x, 1.0 / p);`
`205`	`205`	`}`
`206`	`206`
`207`	`207`	`/**`