fix #349: Remove Twitter as profile image source option due to API restrictions (#541)

* fix: Remove Twitter as profile image source option due to API restrictions

* Use a direct enum comparison (e.g., imageType != ImageType.Twitter) instead of string matching on ToString()

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* Initiate helper method SanitizeImageType

* Comparing enum values via ToString() is fragile and incurs allocations; use a direct enum check (imageType == ImageType.Twitter) instead.

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

* TO fix warning - Moved static method before instance methods

* Converts Twitter ImageType to Anonymous

* Use Linq where statement instead if - to exclude twitter from options

---------

Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>

Author: Krishanthaudayakumara

headapps/MvpSite/MvpSite.Rendering/ViewComponents/Any/MyDataEditViewComponent.cs

@@ -28,7 +28,9 @@ public override async Task<IViewComponentResult> InvokeAsync()
                     Name = model.Name ?? string.Empty,
                     Email = model.Email ?? string.Empty,
                     Country = new Country(model.CountryId),
-                    ImageType = model.ImageType
+
+                    // Clear Twitter ImageType if selected, as Twitter API is no longer available
+                    ImageType = SanitizeImageType(model.ImageType)
                 };
 
                 userResponse = await Client.UpdateCurrentUserAsync(updatedUser);
@@ -44,7 +46,9 @@ public override async Task<IViewComponentResult> InvokeAsync()
                 model.Name = user.Name;
                 model.Email = user.Email;
                 model.CountryId = user.Country?.Id ?? 0;
-                model.ImageType = user.ImageType;
+
+                // Clear Twitter ImageType if selected, as Twitter API is no longer available
+                model.ImageType = SanitizeImageType(user.ImageType);
                 model.ImageUri = user.ImageUri;
                 ModelState.Clear();
             }
@@ -71,6 +75,12 @@ public override async Task<IViewComponentResult> InvokeAsync()
         return result;
     }
 
+    /// Converts Twitter ImageType to Anonymous as Twitter API is no longer available
+    private static ImageType SanitizeImageType(ImageType imageType)
+    {
+        return imageType == ImageType.Twitter ? ImageType.Anonymous : imageType;
+    }
+
     private async Task LoadCountries(MyDataEditModel model)
     {
         Response<IList<Country>> countryResponse = await Client.GetCountriesAsync(1, short.MaxValue);

headapps/MvpSite/MvpSite.Rendering/Views/Shared/Components/AnyMyDataEdit/Default.cshtml

@@ -45,7 +45,8 @@
                 </label>
                 <span class="text-danger">*</span>
                 <select asp-for="ImageType" class="form-control" required>
-                    @foreach (ImageType imageType in Enum.GetValues<ImageType>())
+                    @* Exclude Twitter option as Twitter API is no longer available *@
+                    @foreach (ImageType imageType in Enum.GetValues<ImageType>().Where(x => x != ImageType.Twitter))
                     {
                         <option value="@imageType">@imageType</option>
                     }