Skip to content

Set limit for the MVP contributions #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 9 commits into from
Closed

Set limit for the MVP contributions #558

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
69ca33d
Fix for Remove the MVP titles from the timeline #524
SobiyaChainee Jun 12, 2025
868a8ad
removed commented lines
SobiyaChainee Jun 12, 2025
5b1d906
Merge branch 'Sitecore:main' into main
SobiyaChainee Jun 13, 2025
825297f
Merge branch 'Sitecore:main' into main
SobiyaChainee Jun 24, 2025
22e0e0e
Merge branch 'Sitecore:main' into main
SobiyaChainee Jun 25, 2025
a7fe8a2
Merge branch 'Sitecore:main' into main
SobiyaChainee Jun 26, 2025
4d692a8
Merge branch 'Sitecore:main' into main
SobiyaChainee Jul 4, 2025
f2be366
Merge branch 'Sitecore:main' into main
SobiyaChainee Jul 24, 2025
08495f1
Fix for Set limit for the MVP contributions #556
SobiyaChainee Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions headapps/MvpSite/MvpSite.Rendering/ViewComponents/Apply/ApplicationFormViewComponent.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -432,6 +432,14 @@ private async Task ExecuteContributionsStep(ApplicationFormModel model)
&& model.ContributionDate.Value >= model.CurrentSelection?.ApplicationsEnd.AddMonths(-_options.TimeFrameMonths)
&& model.ContributionDate.Value <= model.CurrentSelection.ApplicationsEnd)
{
if (model.CurrentApplication?.Contributions.Count >= 30)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this value configurable on a Sitecore Item

{
model.NextStep = ApplicationStep.Contributions;
await LoadProducts(model);
ModelState.AddModelError(string.Empty, "You have reached the limit of 30 contributions. Please review your list and select only top 30 contributions.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this text content editable

return;
}

Contribution contribution = new(model.UpdateContributionId ?? Guid.Empty)
{
Date = model.ContributionDate.Value,
Expand Down Expand Up @@ -536,6 +544,13 @@ private async Task ExecuteConfirmationStep(ApplicationFormModel model)
{
if (model.IsNavigation.HasValue && model.IsNavigation.Value)
{
if (model.CurrentApplication?.Contributions.Count < 3)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this value configurable on a Sitecore Item.

{
ModelState.AddModelError(string.Empty, "You must add atleast 3 contributions to submit your application.");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Make this text content editable

model.NextStep = ApplicationStep.Contributions;
return;
}

model.NextStep = ApplicationStep.Confirmation;
}
else if (model.IsNavigation.HasValue && !model.IsNavigation.Value && model.UnderstandsReviewConsent && model is { UnderstandsProgramAgreement: true, IsComplete: true, CurrentApplication: not null })
Expand Down
Loading