Skip to content

Conversation

@markfili
Copy link

  • removed unused StreamingCore.kt that was causing build problems
  • upgraded kotlin version to 1.7.21
  • upgraded plugin version to 2.0.1 to indicate a fix to 2.0.0

@markfili markfili mentioned this pull request Jan 25, 2023
@markfili
Copy link
Author

had to fix a NullPointerException when the default source is not acc so the plugin was updated to v2.0.2 accordingly

@markfili
Copy link
Author

fixed the iOs side, fetching metadata from a different type (group instead of item)

@markfili
Copy link
Author

markfili commented Feb 2, 2023

  • moved player initialization to before media sources are set to ensure the player is "always" initialized correctly
  • disabled showing a stop button in the notification player controls because when the player is stopped, the service will be unbound/unregistered so the playlist cannot be resumed normally
  • added some TODOs with ideas to consider
  • upgraded Android gradle

@markfili
Copy link
Author

markfili commented Feb 2, 2023

@Sithira when you get to this message, please contact me if you want to discuss what happened in this PR because at this point I have heavily modified the Android side of the plugin in such way that it conforms to my current needs. My opinion is that this plugin is on the right track but requires more work and needs to do some things differently in order to become more powerful and usable to a common developer. Now that I've become somewhat familiar with it, I would love to discuss its future with you as I won't have the time to fix it alone and I'm sure you're busy, too.

@Sithira
Copy link
Owner

Sithira commented Apr 17, 2023

@markfili i would love have a discussion with you regarding the changes you have made

@markfili
Copy link
Author

@Sithira sure, I just need to remind myself what was done 😁

@Sithira
Copy link
Owner

Sithira commented Dec 23, 2023

@markfili I'm sorry for the extreme delay. I know this is way too late. But would be rebase your changes and resubmit your PR ? Your changes seems promising

@markfili
Copy link
Author

markfili commented Dec 23, 2023 via email

@Sithira
Copy link
Owner

Sithira commented Dec 23, 2023 via email

Fixes and upgrades on the radio service
@markfili markfili reopened this Jan 15, 2024
@markfili
Copy link
Author

@Sithira Hello!

here you go, I've synced changes in this PR with lastest changes on your repository and I suggest you test everything thoroughly before merging so you know for sure what was changed and how it behaves now :) there might be some Flutter package updates you'll have to solve but I think it's good to update deps from time to time :)

@markfili markfili changed the title remove unused class Remove unused class, change initialisation steps, fix metadata, upgrade dependencies Jan 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants