Merge pull request #362 from marklagendijk/aws-s3-client-provider #640
Annotations
20 warnings
|
tests/ImageSharp.Web.Tests/Commands/CommandParserTests.cs#L240
The behavior of 'StringBuilder.AppendFormat(string, params object[])' could vary based on the current user's locale settings. Replace this call in 'CommandParserTests.ToNumericList<T>(CultureInfo, params T[])' with a call to 'StringBuilder.AppendFormat(IFormatProvider, string, params object[])'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
tests/ImageSharp.Web.Tests/Caching/HexEncoderTests.cs#L37
Prefer static 'System.Security.Cryptography.SHA256.HashData' method over 'ComputeHash' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1850)
|
|
tests/ImageSharp.Web.Tests/Caching/HexEncoderTests.cs#L19
The behavior of 'byte.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'HexEncoderTests.HexEncoderOutputIsCorrect()' with a call to 'byte.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
tests/ImageSharp.Web.Tests/Caching/CacheHashTests.cs#L62
The behavior of 'int.ToString()' could vary based on the current user's locale settings. Replace this call in 'CacheHashTests.CreateLongString()' with a call to 'int.ToString(IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
tests/ImageSharp.Web.Tests/Caching/CacheHashTests.cs#L62
Remove the ToString call in order to use a strongly-typed StringBuilder overload (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1830)
|
|
tests/ImageSharp.Web.Tests/Helpers/FormatUtilitiesTests.cs#L11
Non-constant fields should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2211)
|
|
tests/ImageSharp.Web.Tests/Helpers/ExifOrientationUtilitiesTests.cs#L73
Non-constant fields should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2211)
|
|
tests/ImageSharp.Web.Tests/Helpers/ExifOrientationUtilitiesTests.cs#L50
Non-constant fields should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2211)
|
|
tests/ImageSharp.Web.Tests/Helpers/ExifOrientationUtilitiesTests.cs#L26
Non-constant fields should not be visible (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2211)
|
|
tests/ImageSharp.Web.Tests/TestUtilities/TestServerFixture.cs#L71
The annotation for nullable reference types should only be used in code within a '#nullable' annotations context.
|
|
tests/ImageSharp.Web.Benchmarks/Caching/CacheHashBenchmarks.cs#L23
Member 'HashUsingSha256' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
tests/ImageSharp.Web.Benchmarks/Caching/CacheHashBaseline.cs#L27
Prefer static 'System.Security.Cryptography.SHA256.HashData' method over 'ComputeHash' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1850)
|
|
tests/ImageSharp.Web.Benchmarks/Caching/ToHexBenchmarks.cs#L66
Prefer static 'System.Security.Cryptography.SHA256.HashData' method over 'ComputeHash' (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1850)
|
|
tests/ImageSharp.Web.Benchmarks/Caching/CacheHashBenchmarks.cs#L20
Member 'HashUsingBaselineHash' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
tests/ImageSharp.Web.Benchmarks/Caching/ToHexBenchmarks.cs#L55
Member 'CustomToHexUnsafe' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
tests/ImageSharp.Web.Benchmarks/Synchronization/AsyncLockBenchmarks.cs#L14
Type 'AsyncLockBenchmarks' owns disposable field(s) 'asyncKeyLock', 'asyncLock' but is not disposable (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1001)
|
|
tests/ImageSharp.Web.Benchmarks/Caching/CacheHashBaseline.cs#L31
The behavior of 'byte.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'CacheHashBaseline.Create(string, uint)' with a call to 'byte.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
|
tests/ImageSharp.Web.Benchmarks/Caching/ToHexBenchmarks.cs#L31
Member 'CustomToHex' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
tests/ImageSharp.Web.Benchmarks/Caching/ToHexBenchmarks.cs#L18
Member 'StringBuilderToHex' does not access instance data and can be marked as static (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1822)
|
|
tests/ImageSharp.Web.Benchmarks/Caching/ToHexBenchmarks.cs#L24
The behavior of 'byte.ToString(string)' could vary based on the current user's locale settings. Replace this call in 'ToHexBenchmarks.StringBuilderToHex()' with a call to 'byte.ToString(string, IFormatProvider)'. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1305)
|
The logs for this run have expired and are no longer available.
Loading