Skip to content

WIP - [no jira]: Full SSR, Hard Source plugin #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 0 commits into from

Conversation

olliecurtis
Copy link
Member

For more context see #77 .

This PR is to align #77 to BRS v8 for testing before further exploration of configurability for our consumers.

@olliecurtis
Copy link
Member Author

Placing this CI failed run here for future reference for making these things opt-in: https://travis-ci.org/github/Skyscanner/backpack-react-scripts/jobs/717909653

CI failed here as the app paths have been changed in the config.js to support SSR at a particular run which for non SSR consumers modifying these paths would mean that they don't get generated properly so would need to look at the impact on that when people use BRS and serve their website

@olliecurtis olliecurtis force-pushed the fork branch 3 times, most recently from 8d3485c to ab589e3 Compare August 18, 2020 09:39
@olliecurtis olliecurtis marked this pull request as ready for review August 25, 2020 16:31
@olliecurtis olliecurtis changed the title [no jira]: Full SSR, Hard Source plugin WIP - [no jira]: Full SSR, Hard Source plugin Aug 25, 2020
@olliecurtis olliecurtis changed the base branch from fork to BPK-2599-backpack-react-scripts-8 August 25, 2020 16:31
@olliecurtis olliecurtis changed the base branch from BPK-2599-backpack-react-scripts-8 to fork August 25, 2020 16:32
@olliecurtis
Copy link
Member Author

Closing as some strange diff behaviour is occuring

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant