BRS 8 - Full SSR Hard Source and Loadable support #85
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The travis build is expected to fail here as the app paths have been changed in the config.js to support SSR at a particular run which for non SSR consumers modifying these paths would mean that they don't get generated properly so would need to look at the impact on that when people use BRS and serve their website |
|
Diff looks perfect @olliecurtis, nice spot with the CSS |
olliecurtis
force-pushed
the
no-jira-custom-full-ssr-hard-source
branch
from
c6892c8 to
9ab25eb
Compare
olliecurtis
commented
Sep 11, 2020
| const appName = require(paths.appPackageJson).name; | ||
| const useYarn = fs.existsSync(paths.yarnLockFile); | ||
|
|
||
| const compiler = createCompiler(webpack, config, appName, undefined, useYarn); |
There was a problem hiding this comment.
Turns out the params of this function have changed to accept an object of these parameters so will update with the correct expected format for this
See here for example: https://github.com/Skyscanner/backpack-react-scripts/blob/9ab25eb68904847805d4a5681ab7e6a8620f0845/packages/react-scripts/scripts/start.js#L115
olliecurtis
force-pushed
the
fork
branch
2 times, most recently
from
50e36ad to
93ba2ab
Compare
olliecurtis
force-pushed
the
no-jira-custom-full-ssr-hard-source
branch
from
cadd3b2 to
e8169e3
Compare
olliecurtis
force-pushed
the
fork
branch
2 times, most recently
from
2defef8 to
1904fcb
Compare
olliecurtis
force-pushed
the
no-jira-custom-full-ssr-hard-source
branch
from
e8169e3 to
9f75d1e
Compare
olliecurtis
changed the title
olliecurtis
changed the title
olliecurtis
force-pushed
the
no-jira-custom-full-ssr-hard-source
branch
from
6ffad9e to
af12611
Compare
olliecurtis
force-pushed
the
fork
branch
5 times, most recently
from
4670103 to
588bc2b
Compare
olliecurtis
force-pushed
the
fork
branch
9 times, most recently
from
222896f to
a9e5e80
Compare
olliecurtis
force-pushed
the
fork
branch
3 times, most recently
from
3342ce3 to
2497e97
Compare
olliecurtis
force-pushed
the
fork
branch
5 times, most recently
from
1244339 to
dad0045
Compare
olliecurtis
force-pushed
the
fork
branch
4 times, most recently
from
40a7d29 to
db95f43
Compare
olliecurtis
force-pushed
the
fork
branch
4 times, most recently
from
0bd6040 to
73cfa32
Compare
olliecurtis
changed the title
olliecurtis
force-pushed
the
no-jira-custom-full-ssr-hard-source
branch
2 times, most recently
from
640ad0d to
2f44efd
Compare
olliecurtis
force-pushed
the
no-jira-custom-full-ssr-hard-source
branch
from
2f44efd to
d088ad5
Compare
|
As BRS 9 is the current supported version and BRS 10 is on the way closing this PR for now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For more context see #77 .
This PR is to align #77 to BRS v8 for testing before further exploration of configurability for our consumers.