Skip to content

Conversation

@voprokudin
Copy link
Collaborator

@voprokudin voprokudin commented Jan 28, 2022

The amount of LOC of your project without comments and empty lines

@voprokudin voprokudin requested a review from Skyyo January 28, 2022 14:49
Copy link
Owner

@Skyyo Skyyo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. Looks there are a lot of redundant files( license eg) . In case we've simply copy pasted a ready solution - better to fork it to our organisation repo and include in gitHub actions as is, instead of manually pasting these files in each app. The workflows also should documented
    eg:
    step 1 check out
    step 2. what uses: ./app does
    etc.
    Also it's important to understand that we might have multi module projects in the future, this this solution should be capable of doing the same job for those projects.

  2. Please add a description of what each file here is responsible for and complete flow description, with specifications of what exactly is counted. Details matter, so specifying if it counts all Kotlin code, or it will omit kotlin gradle files might be important for some cases.

Overall, seems it's possible to move this into a gitHub action which won't bloat the project. Contact me please when documentation is done so we can discuss this scenario.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants