Skip to content

Conversation

RenanMsV
Copy link
Contributor

Description

There is a typo in the file AGenerator.java. Its only in the warn, so its a simple and easy fix.

Proposed changes

Replacing setEnergyCapacity with setCapacity.

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

Replaced setEnergyCapacity with setCapacity.
@RenanMsV RenanMsV requested a review from a team as a code owner August 27, 2024 04:46
Copy link
Contributor

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

@JustAHuman-xD JustAHuman-xD added the 🧹 Chores Refactoring / Cleanup. label Aug 27, 2024
Copy link
Contributor

@JustAHuman-xD JustAHuman-xD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Nice catch

Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: d59678b

https://preview-builds.walshy.dev/download/Slimefun/4227/d59678b8

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Copy link
Member

@Alessio-Colombo Alessio-Colombo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Alessio-Colombo Alessio-Colombo merged commit 7d2ccc2 into Slimefun:master Sep 6, 2024
15 checks passed
@RenanMsV RenanMsV deleted the patch-AGenerator-typo branch September 6, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Chores Refactoring / Cleanup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants