Skip to content

Conversation

Intybyte
Copy link
Contributor

@Intybyte Intybyte commented Sep 8, 2024

Description

Refactoring of the class

Proposed changes

Early continue after checking the similarity of the ItemStack and extracting CargoUtils#handleStack

Related Issues (if applicable)

CargoUtils#insert
CargoUtils#insertIntoVanillaInventory

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@Intybyte Intybyte requested a review from a team as a code owner September 8, 2024 14:14
@github-actions github-actions bot added the 🧹 Chores Refactoring / Cleanup. label Sep 8, 2024
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Your Pull Request was automatically labelled as: "🧹 Chores"
Thank you for contributing to this project! ❤️

Copy link
Contributor

github-actions bot commented Sep 8, 2024

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: f05c814

https://preview-builds.walshy.dev/download/Slimefun/4235/f05c814a

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Chores Refactoring / Cleanup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant