Skip to content

Conversation

ybw0014
Copy link
Contributor

@ybw0014 ybw0014 commented Sep 8, 2024

Description

Quick fix the issues for backward compatibility with 1.16 and 1.17.

Proposed changes

Use the parse method from JsonUtils.

Related Issues (if applicable)

N/A

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@ybw0014 ybw0014 requested a review from a team as a code owner September 8, 2024 23:08
@github-actions github-actions bot added the 🧹 Chores Refactoring / Cleanup. label Sep 8, 2024
Copy link
Contributor

github-actions bot commented Sep 8, 2024

Your Pull Request was automatically labelled as: "🧹 Chores"
Thank you for contributing to this project! ❤️

@ybw0014 ybw0014 closed this Sep 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🧹 Chores Refactoring / Cleanup.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant