Updates usages of CustomItemStack #4253
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Your Pull Request was automatically labelled as: "✨ Fix" |
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4253/00d0a289
|
src/main/java/io/github/thebusybiscuit/slimefun4/utils/itemstack/ColoredFireworkStar.java
Outdated
Show resolved
Hide resolved
WalshyDev
reviewed
Nov 9, 2024
WalshyDev
approved these changes
Nov 9, 2024
WalshyDev
added a commit
that referenced
this pull request
Mar 9, 2025
**Note: This is experimental and will break all addons not yet supporting 1.21! Use at your own risk** * Update to 1.21 * Add a temporary InventoryViewWrapper in tests. Refactor TestBackpackListener to use the wrapper on Player#getOpenInventory * Wrap the inventory view after the backpack has been opened * Updates usages of CustomItemStack (#4253) Co-authored-by: Daniel Walsh <walshydev@gmail.com> * Remove EnumMap and EnumSet usages (#4258) --------- Co-authored-by: Andrew Wong <42793301+md5sha256@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updates to match dough's refactored CustomItemStack (which no longer extends ItemStack)
Updates the mockbukkit dependency to latest from maven central (not jitpack)
Proposed changes
Related Issues (if applicable)
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values