Add permission check to SF Search in cheat mode#4266
Closed
JustAHuman-xD wants to merge 2 commits intomasterfrom
Closed
Add permission check to SF Search in cheat mode#4266JustAHuman-xD wants to merge 2 commits intomasterfrom
JustAHuman-xD wants to merge 2 commits intomasterfrom
Conversation
Contributor
|
Your Pull Request was automatically labelled as: "✨ Fix" |
|
Contributor
Slimefun preview buildA Slimefun preview build is available for testing! https://preview-builds.walshy.dev/download/Slimefun/4266/15217555
|
TheBusyBiscuit
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In the unlikely event someone manages to get a cheat sheet they can cheat in items with the search feature, we don’t want that.
Proposed changes
Change the logic for search items to match the logic for normal items when clicked. (Have a permission check for cheating, cheat in stack when shifting)
Related Issues (if applicable)
Checklist
NonnullandNullableannotations to my methods to indicate their behaviour for null values