Skip to content

Conversation

Outfit8TSB
Copy link

Warning

This Pull has been rewritten due to a mistake. it was supposed to be walshy/mc-1.21, not master.
Original Pull: #4291, Current: #4292

Description

the Merge Conflict has occurred on #4248.
merging the branch compatibility/mc-1.21.4 may resolve the stalemate.

Proposed changes

bump Maven Javadoc Plugin making it same as master.

Related Issues (if applicable)

Resolves Merge Conflict.

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

Intybyte and others added 23 commits November 9, 2024 19:28
Co-authored-by: Daniel Walsh <walshydev@gmail.com>
…fun#4244)

* Add simple `BlockPosition` based helpers for BlockStorage to help ease the transition between `Location` and `BlockStorage`

* Fix build.
@Outfit8TSB Outfit8TSB requested review from a team as code owners February 9, 2025 09:51
@github-actions github-actions bot added the 🤝 Compatibility This Pull Request introduces a compatibility feature. label Feb 9, 2025
Copy link
Contributor

github-actions bot commented Feb 9, 2025

Your Pull Request was automatically labelled as: "🤝 Compatibility"
Thank you for contributing to this project! ❤️

@WalshyDev WalshyDev deleted the branch Slimefun:walshy/mc-1.21 March 9, 2025 12:46
@WalshyDev WalshyDev closed this Mar 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🤝 Compatibility This Pull Request introduces a compatibility feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants