Skip to content

Conversation

ybw0014
Copy link
Contributor

@ybw0014 ybw0014 commented Mar 10, 2025

Description

The HttpClient in metrics service does not allow redirects by default, which will fail to download module all the time.

Proposed changes

  • Set the redirect policy to normal (allow redirects except HTTPS to HTTP)

Related Issues (if applicable)

N/A

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

@ybw0014 ybw0014 requested a review from a team as a code owner March 10, 2025 20:45
@github-actions github-actions bot added the ✨ Fix This Pull Request fixes an issue. label Mar 10, 2025
Copy link
Contributor

Your Pull Request was automatically labelled as: "✨ Fix"
Thank you for contributing to this project! ❤️

@ybw0014 ybw0014 requested a review from a team as a code owner March 10, 2025 20:47
Copy link
Contributor

Slimefun preview build

A Slimefun preview build is available for testing!
Commit: 28c6c6d

https://preview-builds.walshy.dev/download/Slimefun/4301/28c6c6d5

Note: This is not a supported build and is only here for the purposes of testing.
Do not run this on a live server and do not report bugs anywhere but this PR!

@WalshyDev WalshyDev merged commit 82419dc into Slimefun:master Mar 10, 2025
13 checks passed
@ybw0014 ybw0014 deleted the fix/metrics branch March 28, 2025 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Fix This Pull Request fixes an issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants