-
Notifications
You must be signed in to change notification settings - Fork 589
Replace copper ingot with copper from original Minecraft. #4306
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: experimental
Are you sure you want to change the base?
Replace copper ingot with copper from original Minecraft. #4306
Conversation
…opper Ingot. on 1.17, the copper was added, however, slimefun didnt removed it yet. causing the copper ingot(sf) still remaining. this commit removes Copper Ingot(SF) in favor of Copper ingot from vanilla minecraft. all users used this version to make a new addon should replace all usage of SlimefunItems.COPPER_INGOT to new ItemStack(Material.COPPER_INGOT)
…Ingot(MC) on 1.17, the copper was added, however, slimefun didnt removed it yet. causing the copper ingot(sf) still remaining. this commit removes Copper Ingot(SF) in favor of Copper ingot from vanilla minecraft. all users used this version to make a new addon should replace all usage of SlimefunItems.COPPER_INGOT to new ItemStack(Material.COPPER_INGOT)
Pro Tip!
If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀 |
I think this would never be considered before the recipe system rewrite (support interchangeable ingredients), but we can see what admins think. |
agreed ybw. there's too much impact that wasn't considered as it will affect every addon and break them all, along with every players base, sorting systems, network systems, etc., much more care has to be put into this before it would be rolled out |
D'oh, i didnt reailze that. 😵 |
Let's ship it on Slimefun 5! |
shush! no saying about slimefun 5. this is slimefun 4. |
it should fix Error: /home/runner/work/Slimefun4/Slimefun4/src/main/java/io/github/thebusybiscuit/slimefun4/implementation/setup/SlimefunItemSetup.java:[592,48] incompatible types: org.bukkit.inventory.ItemStack cannot be converted to io.github.thebusybiscuit.slimefun4.api.items.SlimefunItemStack. i will just look into more codes...
remove Slimefunitems.COPPER_INGOT. fixes Error: /home/runner/work/Slimefun4/Slimefun4/src/main/java/io/github/thebusybiscuit/slimefun4/implementation/setup/ResearchSetup.java:[70,71] cannot find symbol Error: symbol: variable COPPER_INGOT Error: location: class io.github.thebusybiscuit.slimefun4.implementation.SlimefunItems
Description
on 1.17, the copper was added,
however, slimefun didnt removed it yet. causing the copper ingot(sf) still remaining.
this commit replaces Copper Ingot(SF) in favor of Copper ingot from vanilla minecraft.
all users making a new addon
should replace all usage of SlimefunItems.COPPER_INGOT to new ItemStack(Material.COPPER_INGOT).
Proposed changes
Remove SlimefunItems.COPPER_INGOT and replace with new ItemStack(Material.COPPER_INGOT)
Related Issues (if applicable)
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values