Skip to content

Conversation

Outfit8TSB
Copy link

Description

on 1.17, the copper was added,
however, slimefun didnt removed it yet. causing the copper ingot(sf) still remaining.
this commit replaces Copper Ingot(SF) in favor of Copper ingot from vanilla minecraft.

all users making a new addon
should replace all usage of SlimefunItems.COPPER_INGOT to new ItemStack(Material.COPPER_INGOT).

Proposed changes

Remove SlimefunItems.COPPER_INGOT and replace with new ItemStack(Material.COPPER_INGOT)

Related Issues (if applicable)

Checklist

  • I have fully tested the proposed changes and promise that they will not break everything into chaos.
  • I have also tested the proposed changes in combination with various popular addons and can confirm my changes do not break them.
  • I have made sure that the proposed changes do not break compatibility across the supported Minecraft versions (1.16.* - 1.20.*).
  • I followed the existing code standards and didn't mess up the formatting.
  • I did my best to add documentation to any public classes or methods I added.
  • I have added Nonnull and Nullable annotations to my methods to indicate their behaviour for null values
  • I added sufficient Unit Tests to cover my code.

…opper Ingot.

on 1.17, the copper was added,
however, slimefun didnt removed it yet. causing the copper ingot(sf) still remaining.
this commit removes Copper Ingot(SF) in favor of Copper ingot from vanilla minecraft.

all users used this version to make a new addon
should replace all usage of SlimefunItems.COPPER_INGOT to new ItemStack(Material.COPPER_INGOT)
…Ingot(MC)

on 1.17, the copper was added,
however, slimefun didnt removed it yet. causing the copper ingot(sf) still remaining.
this commit removes Copper Ingot(SF) in favor of Copper ingot from vanilla minecraft.

all users used this version to make a new addon
should replace all usage of SlimefunItems.COPPER_INGOT to new ItemStack(Material.COPPER_INGOT)
@Outfit8TSB Outfit8TSB requested a review from a team as a code owner April 7, 2025 13:54
Copy link
Contributor

github-actions bot commented Apr 7, 2025

Pro Tip!
You can help us label your Pull Requests by using the following branch naming convention next time you create a pull request. ❤️

Branch naming convention Label
feature/** 🎈 Feature
fix/** ✨ Fix
chore/** 🧹 Chores
api/** 🔧 API
performance/** 💡 Performance Optimization
compatibility/** 🤝 Compatibility

If your changes do not fall into any of these categories, don't worry. You can just ignore this message in that case! 👀

@ybw0014
Copy link
Contributor

ybw0014 commented Apr 7, 2025

I think this would never be considered before the recipe system rewrite (support interchangeable ingredients), but we can see what admins think.

@Boomer-1
Copy link

Boomer-1 commented Apr 7, 2025

agreed ybw. there's too much impact that wasn't considered as it will affect every addon and break them all, along with every players base, sorting systems, network systems, etc., much more care has to be put into this before it would be rolled out

@Outfit8TSB
Copy link
Author

D'oh, i didnt reailze that. 😵
But you should consider that Copper was Added in 1.17.
but the copper from slimefun was really like existed in 1.17~1.21. Why do you even want to keep it? They are @Deprecated. It Must be replaced with new Itemstack(Material.COPPER_INGOT).
If Slimefun copper is there, whats the point for Copper in Minecraft?
For that, i think the old SlimefunItems.COPPER_INGOT Should be removed,
And Must be replaced to new ItemStack(Material.COPPER_INGOT).

@gphg
Copy link

gphg commented Apr 9, 2025

Let's ship it on Slimefun 5!

@Outfit8TSB
Copy link
Author

Let's ship it on Slimefun 5!

shush! no saying about slimefun 5. this is slimefun 4.

@TheBusyBiscuit TheBusyBiscuit added the 🎈 Feature This Pull Request adds a new feature. label Apr 14, 2025
it should fix Error:  /home/runner/work/Slimefun4/Slimefun4/src/main/java/io/github/thebusybiscuit/slimefun4/implementation/setup/SlimefunItemSetup.java:[592,48] incompatible types: org.bukkit.inventory.ItemStack cannot be converted to io.github.thebusybiscuit.slimefun4.api.items.SlimefunItemStack.
i will just look into more codes...
remove Slimefunitems.COPPER_INGOT. 
fixes 
Error:  /home/runner/work/Slimefun4/Slimefun4/src/main/java/io/github/thebusybiscuit/slimefun4/implementation/setup/ResearchSetup.java:[70,71] cannot find symbol
Error:    symbol:   variable COPPER_INGOT
Error:    location: class io.github.thebusybiscuit.slimefun4.implementation.SlimefunItems
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎈 Feature This Pull Request adds a new feature.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants