fix: remove bartering drop order bias by shuffling candidates (#4326) #4337
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes the issue where the piglin barter drop uses a
HashSet
for iteration, which results in a deterministic order after the set is finalized.Proposed changes
SlimefunRegistry
calledgetRandomizedBarteringDrops()
, which copies thebarterDrops
into aList
and shuffles it withThreadLocalRandom
.HashSet
.Related Issues (if applicable)
Resolves #4326
Checklist
Nonnull
andNullable
annotations to my methods to indicate their behaviour for null values