-
Notifications
You must be signed in to change notification settings - Fork 40
Support 1.20.6 #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Support 1.20.6 #271
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
47885b6
Support 1.20.6 and add paper adapters
EpicPlayerA10 4f9f7cb
remove space
EpicPlayerA10 68cb6ac
reduce to one call
EpicPlayerA10 fa590a0
fix build due to funnyguilds invalid dependency
EpicPlayerA10 9826839
use registry instead of enum
EpicPlayerA10 b1676fc
fix: use old getter of property for older versions
ybw0014 5140054
Merge pull request #1 from GuizhanCraft/update/1.20.6
EpicPlayerA10 66870dd
Put paper adapter behind 1.19.4 gate
WalshyDev 67f9cb9
Disable paper head adapter
WalshyDev File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
32 changes: 32 additions & 0 deletions
32
dough-items/src/main/java/io/github/bakedlibs/dough/items/nms/ItemNameAdapter20v5.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,32 @@ | ||
| package io.github.bakedlibs.dough.items.nms; | ||
|
|
||
| import io.github.bakedlibs.dough.reflection.ReflectionUtils; | ||
| import io.github.bakedlibs.dough.versions.UnknownServerVersionException; | ||
| import org.bukkit.inventory.ItemStack; | ||
|
|
||
| import javax.annotation.ParametersAreNonnullByDefault; | ||
| import java.lang.reflect.InvocationTargetException; | ||
| import java.lang.reflect.Method; | ||
|
|
||
| class ItemNameAdapter20v5 implements ItemNameAdapter { | ||
|
|
||
| private final Method getCopy; | ||
| private final Method getName; | ||
| private final Method toString; | ||
|
|
||
| ItemNameAdapter20v5() throws NoSuchMethodException, SecurityException, ClassNotFoundException, UnknownServerVersionException { | ||
| super(); | ||
|
|
||
| getCopy = ReflectionUtils.getOBCClass("inventory.CraftItemStack").getMethod("asNMSCopy", ItemStack.class); | ||
| getName = ReflectionUtils.getMethodOrAlternative(ReflectionUtils.getNetMinecraftClass("world.item.ItemStack"), "getDisplayName", "G"); | ||
| toString = ReflectionUtils.getMethod(ReflectionUtils.getNetMinecraftClass("network.chat.IChatBaseComponent"), "getString"); | ||
| } | ||
|
|
||
| @Override | ||
| @ParametersAreNonnullByDefault | ||
| public String getName(ItemStack item) throws IllegalAccessException, InvocationTargetException { | ||
| Object instance = getCopy.invoke(null, item); | ||
| return (String) toString.invoke(getName.invoke(instance)); | ||
| } | ||
|
|
||
| } |
16 changes: 16 additions & 0 deletions
16
dough-items/src/main/java/io/github/bakedlibs/dough/items/nms/ItemNameAdapterPaper.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,16 @@ | ||
| package io.github.bakedlibs.dough.items.nms; | ||
|
|
||
| import net.kyori.adventure.text.serializer.plain.PlainTextComponentSerializer; | ||
| import org.bukkit.Bukkit; | ||
| import org.bukkit.inventory.ItemStack; | ||
|
|
||
| import javax.annotation.ParametersAreNonnullByDefault; | ||
| import java.lang.reflect.InvocationTargetException; | ||
|
|
||
| public class ItemNameAdapterPaper implements ItemNameAdapter { | ||
| @Override | ||
| @ParametersAreNonnullByDefault | ||
| public String getName(ItemStack item) throws IllegalAccessException, InvocationTargetException { | ||
| return PlainTextComponentSerializer.plainText().serialize(Bukkit.getItemFactory().displayName(item)); | ||
| } | ||
| } |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.