Skip to content

FIx dough-common and co being on the wrong scope in dough modules #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

FIx dough-common and co being on the wrong scope in dough modules #84

wants to merge 3 commits into from

Conversation

md5sha256
Copy link
Contributor

No description provided.

@TheBusyBiscuit
Copy link
Member

Is it the wrong scope though?
Won't this cause issues and shade those into other modules?

@md5sha256
Copy link
Contributor Author

Walshy mentioned that it was on the wrong scope. I'm not sure why so I guess I'll have to ping here and ask for the explanation. @WalshyDev

@WalshyDev
Copy link
Member

Yeah, right now you can't just use a singular module. It should include all the needed dependencies but in this case, it doesn't. Meaning I need to specify common myself

There should be no issues in any modules if the deps are just done correctly. For example, the item module shouldn't include common in since it'll be inherited already through reflections

This is common practice

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@md5sha256 @TheBusyBiscuit @WalshyDev