add extra chekcs in soil moisture measurement limits handler

Author: nickolas-deboom

drivers/SmartThings/matter-sensor/src/sensor_handlers/attribute_handlers.lua

@@ -91,11 +91,15 @@ function AttributeHandlers.soil_moisture_measurement_limits_handler(driver, devi
     ib.data.elements.min_measured_value == nil or ib.data.elements.min_measured_value.value == nil or
     ib.data.elements.max_measured_value == nil or ib.data.elements.max_measured_value.value == nil or
     ib.data.elements.min_measured_value.value >= ib.data.elements.max_measured_value.value then
-    device.log.warn_with({hub_logs = true}, "Device reported invalid soil moisture limits")
+    local min_val = ib.data.elements and ib.data.elements.min_measured_value and ib.data.elements.min_measured_value.value
+    local max_val = ib.data.elements and ib.data.elements.max_measured_value and ib.data.elements.max_measured_value.value
+    device.log.warn_with({hub_logs = true}, string.format("Device reported invalid soil moisture limits: min=%s, max=%s", tostring(min_val), tostring(max_val)))
     return
   end
-  sensor_utils.set_field_for_endpoint(device, fields.SOIL_LIMIT_MIN, ib.endpoint_id, ib.data.elements.min_measured_value.value)
-  sensor_utils.set_field_for_endpoint(device, fields.SOIL_LIMIT_MAX, ib.endpoint_id, ib.data.elements.max_measured_value.value)
+  local min_val = math.max(ib.data.elements.min_measured_value.value, sensor_utils.SOIL_MOISTURE_MIN)
+  local max_val = math.min(ib.data.elements.max_measured_value.value, sensor_utils.SOIL_MOISTURE_MAX)
+  sensor_utils.set_field_for_endpoint(device, fields.SOIL_LIMIT_MIN, ib.endpoint_id, min_val)
+  sensor_utils.set_field_for_endpoint(device, fields.SOIL_LIMIT_MAX, ib.endpoint_id, max_val)
 end
 
 

drivers/SmartThings/matter-sensor/src/sensor_utils/utils.lua

@@ -3,6 +3,10 @@
 
 local utils = {}
 
+-- Sanity check bounds for soil moisture measurement limits (percent)
+utils.SOIL_MOISTURE_MIN = 0
+utils.SOIL_MOISTURE_MAX = 100
+
 function utils.get_field_for_endpoint(device, field, endpoint)
   return device:get_field(string.format("%s_%d", field, endpoint))
 end