-
Notifications
You must be signed in to change notification settings - Fork 517
WWSTCERT-8408 add HOPOsmart window opener A2230011 #2465
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WWSTCERT-8408 add HOPOsmart window opener A2230011 #2465
Conversation
|
Duplicate profile check: Passed - no duplicate profiles detected. |
|
Channel deleted. |
Test Results 71 files 465 suites 0s ⏱️ Results for commit fbfbc3a. ♻️ This comment has been updated with latest results. |
|
Minimum allowed coverage is Generated by 🐒 cobertura-action against fbfbc3a |
bce2e34 to
8261d47
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a fairly generic profile, please use a fairly generic name.
I'd suggest window-shade-only.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Since this is a fairly generic profile, please use a fairly generic name.
I'd suggest
window-shade-only.
Hi, @greens . The category of this profile is WindowOpener rather than the more generic Window. Would it be fine to change the profile name to window-shade-only?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please omit the brand name from the profile name.
greens
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than the profile name change, this looks good, but you will need to rebase your branch to incorporate upstream changes and eliminate merge conflicts.
bd82258 to
1fa2c55
Compare
|
@thinkaName You'll need to rebase or merge in the upstream changes to remove the conflict. |
1fa2c55 to
fbfbc3a
Compare
Check all that apply
Type of Change
Checklist
Description of Change
Summary of Completed Tests