Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .pre-commit-config.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -31,8 +31,8 @@ repos:
args: [ --fix ]
# Run the formatter.
- id: ruff-format
- repo: git@github.com:GitGuardian/ggshield.git
rev: v1.28.0
- repo: https://github.com/gitguardian/ggshield
rev: v1.36.0
hooks:
- id: ggshield
language_version: python3
Expand Down
6 changes: 5 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,11 @@ All notable changes to this project will be documented in this file.

*The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/), and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).*

## [4.0.0] - TBD
## [4.0.1] - 2025-02-17
### Changed
- Added back the ability to pass the Snowflake password in the `SNOWFLAKE_PASSWORD` environment variable.

## [4.0.0] - 2025-01-06
### Added
- Use of `structlog~=24.1.0` for standard log outputs
- Verified Schemachange against Python 3.12
Expand Down
2 changes: 1 addition & 1 deletion schemachange/cli.py
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@

# region Global Variables
# metadata
SCHEMACHANGE_VERSION = "4.0.0"
SCHEMACHANGE_VERSION = "4.0.1"
SNOWFLAKE_APPLICATION_NAME = "schemachange"
module_logger = structlog.getLogger(__name__)

Expand Down
11 changes: 6 additions & 5 deletions schemachange/config/DeployConfig.py
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
from schemachange.config.ChangeHistoryTable import ChangeHistoryTable
from schemachange.config.utils import (
get_snowflake_identifier_string,
get_snowflake_password,
)


Expand Down Expand Up @@ -87,9 +88,9 @@ def get_session_kwargs(self) -> dict:
"query_tag": self.query_tag,
}

# TODO: Discuss the need for check for snowflake password before passing the session
# kwargs to open a snowflake session
# snowflake_password = get_snowflake_password()
# if snowflake_password is not None and snowflake_password:
# session_kwargs["password"] = snowflake_password
# If the user supplied the password in the environment variable, add it to the session config
snowflake_password = get_snowflake_password()
if snowflake_password is not None and snowflake_password:
session_kwargs["password"] = snowflake_password

return {k: v for k, v in session_kwargs.items() if v is not None}
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
[metadata]
name = schemachange
version = 4.0.0
version = 4.0.1
description = A Database Change Management tool for Snowflake
long_description = file: README.md
long_description_content_type = text/markdown
Expand Down
2 changes: 1 addition & 1 deletion tests/test_cli_misc.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@


def test_cli_given__schemachange_version_change_updated_in_setup_config_file():
assert SCHEMACHANGE_VERSION == "4.0.0"
assert SCHEMACHANGE_VERSION == "4.0.1"


def test_cli_given__constants_exist():
Expand Down