Skip to content

Conversation

@pgherveou
Copy link
Contributor

@pgherveou pgherveou commented Sep 11, 2024

Bringing in the changes from paritytech/parity-common#859

@pgherveou pgherveou marked this pull request as ready for review September 11, 2024 14:59
@pgherveou
Copy link
Contributor Author

Hey @vgeddes, would you mind reviewing and publishing this update?

@vgeddes vgeddes merged commit a237569 into Snowfork:master Sep 11, 2024
@vgeddes
Copy link
Contributor

vgeddes commented Sep 11, 2024

Thanks @pgherveou. Published a new version at https://crates.io/crates/ethabi-decode/1.1.0

@ordian
Copy link

ordian commented Sep 12, 2024

This should've been published as 2.0 as this is a breaking change.

@pgherveou
Copy link
Contributor Author

This should've been published as 2.0 as this is a breaking change.

Yeah this might trip up some updates, @vgeddes we should yank it and push 2.0 instead, will push a PR for this

@pgherveou pgherveou mentioned this pull request Sep 13, 2024
@ggwpez
Copy link

ggwpez commented Oct 1, 2024

Yes please, this seems to be breaking. I tried to updated in https://github.com/paritytech/try-runtime-cli and encountered weird build errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants