-
Notifications
You must be signed in to change notification settings - Fork 3
Tutorial review learning #33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tutorial review learning #33
Conversation
Thank you for working on this!
|
4e523d3
to
8bb051f
Compare
I just added the admonitions plugin with some suggested default configuration to get rid of the HTML footnotes in the Markdown. |
This also adds the missing figure "6.1"
I just downloaded an example page as PDF via the print dialogue of the browser and it actually looks very reasonable. The links are also working "out-of-the-box". Maybe a hint/ info point referencing the possibility would already be sufficient? |
That PDF does look great! I didn't realize mkdocs had such good print styling, but I suppose it makes sense. The PDFs are distributed with Soar, so I would want to figure out a way to generate them automatically. Headless chrome or selenium or something. I tried I like the look of the admonitions, as well. Part of the reason I marked all of these pages as "under construction" was because the images are not usable when the site is in dark mode. They either need a light background or to be reworked to update automatically for dark mode (the latter is a bit of a production). |
Ah, that is unfortunate that the headless mode does not work. For now, all modified files in this PR have valid images with either a white background or dynamic color switching. Should I revert the warning removal nonetheless or add an admonition providing a hint for the PDF printing possibility? |
Yes, I would leave the admonition in for now; you can change it to be more specific about dark mode being an issue, if you like. |
A polygon had two class variables.
Do you know if there is a new command for no such option: print |
When I put in GitHub still says that SVG file is malformed. |
Interesting... Do you see some kind of error message since I don't get any warning? I just checked the local version in both light and dark mode. It appears to be fine for mkdocs. |
Actually I think the image is fine :D It shows an error in the commits view, but shows properly in the "Files Changed" view. Is this ready merge? |
Yes! |
Great, thanks for the all work! |
Reviewed the tutorials 5, 6, 7 and 8 - they should be in line with the word/pdf version.
I removed the WIP warning for those tutorials. Should we link to the old PDFs nonetheless?
The manual chapter has just some linting adjustments.