Skip to content

Fix links and formating in Procedural knowledge learning #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 17, 2024

Conversation

moschmdt
Copy link
Contributor

PR #37 introduced some formatting errors (sorry!) that were missed by the CI.

This fixes the indenting and replaces the old "numbered" links to other sections with actual links to the corresponding Markdown documentation.

Some parts of the usage section in the procedural knowledge learning chapter of the Soar manual were not included in the cli reference, thus they were moved.

Discussion see SoarGroup#41
@@ -144,6 +144,12 @@ Note that your operating system chooses which program to launch based on the
file type. This feature has not been tested extensively on other platforms.
Certain systems may not allow Soar to launch an external program.

???+ note
For the visualizer to work, you must have Graphviz and DOT installed, which are
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

dot is lowercase, and it is the executable that comes in the Graphviz distribution, so you could probably reword this:

For the visualizer to work, you must install Graphviz, a free third-party tool, and dot must be available in your path.

@garfieldnate
Copy link
Collaborator

Sorry to make you fix content while you were just wanting to fix formatting and links 😅 Thanks for your patience. I'll merge this in.

@garfieldnate garfieldnate merged commit 036cd8c into SoarGroup:main Sep 17, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants