feat(domifa): log des action utilisateur structure

Author: hbalty

packages/backend/src/_common/model/app-log/LogAction.type.ts

@@ -29,6 +29,9 @@ export type LogAction =
   | "IMPORT_USAGERS_FAILED" // Import échoué
   | "DOWNLOAD_IMPORT_TEMPLATE" // Téléchargement modèle Excel
   | "DOWNLOAD_IMPORT_GUIDE" // Téléchargement guide PDF
+  | "USER_ROLE_CHANGE"
+  | "USER_CREATE"
+  | "USER_DELETE"
   // ADMIN
   | "ADMIN_STRUCTURE_VALIDATE"
   | "ADMIN_STRUCTURE_DELETE"

packages/backend/src/modules/app-logs/app-log-context.types.ts

@@ -1,4 +1,4 @@
-import { UserSupervisorRole } from "@domifa/common";
+import { UserStructureRole, UserSupervisorRole } from "@domifa/common";
 
 export type FailedUsagerImportLogContext = {
   // IMPORT_USAGERS_FAILED
@@ -25,3 +25,18 @@ export type AdminUserRoleChangeLogContext = {
   oldRole: UserSupervisorRole;
   newRole: UserSupervisorRole;
 };
+
+export type UserStructureRoleChangeLogContext = {
+  // USER_ROLE_CHANGE
+  userId: number;
+  structureId: number;
+  oldRole: UserStructureRole;
+  newRole: UserStructureRole;
+};
+
+export type UserStructureCreateLogContext = {
+  // USER_CREATE
+  userId: number;
+  structureId: number;
+  role: UserStructureRole;
+};

packages/backend/src/modules/portail-admin/controllers/admin-users/admin-users.controller.ts

@@ -65,7 +65,7 @@ export class AdminUsersController {
     @Res() res: ExpressResponse,
     @Body() registerUserDto: RegisterUserStructureAdminDto
   ): Promise<ExpressResponse> {
-    const userController = new UsersController();
+    const userController = new UsersController(this.appLogsService); // D'ou c'est un mauvaise idée de instancier directement le controleur ici
     await this.appLogsService.create({
       userId: user.id,
       action: "ADMIN_CREATE_USER_STRUCTURE",

packages/backend/src/modules/users/controllers/users.controller.spec.ts

@@ -16,15 +16,25 @@ import { POST_USER_STRUCTURE_BODY } from "../../../_common/mocks";
 import { TESTS_USERS_STRUCTURE } from "../../../_tests";
 import { usersDeletor } from "../services/users-deletor.service";
 import { MailsModule } from "../../mails/mails.module";
+import { AppLogsService } from "../../app-logs/app-logs.service";
 
 describe("Users Controller", () => {
   let controller: UsersController;
   let context: AppTestContext;
-
+  let appLogService: AppLogsService;
   beforeAll(async () => {
+    appLogService = {
+      create: jest.fn(),
+    };
     context = await AppTestHelper.bootstrapTestApp({
       controllers: [UsersController],
       imports: [MailsModule, StructuresModule, UsagersModule, HttpModule],
+      providers: [
+        {
+          provide: AppLogsService,
+          useValue: appLogService,
+        },
+      ],
     });
 
     const authInfo =
@@ -54,7 +64,14 @@ describe("Users Controller", () => {
             structure: { ...POST_USER_STRUCTURE_BODY.structure, id: 1 },
           },
         });
-
+        expect(appLogService.create).toHaveBeenCalledWith({
+          action: "USER_CREATE",
+          context: {
+            role: POST_USER_STRUCTURE_BODY.role,
+            structureId: 1,
+            userId: POST_USER_STRUCTURE_BODY.id,
+          },
+        });
         expect(response.status).toBe(200);
         expect(response.text).toBe('{"message":"OK"}');
       });

packages/backend/src/modules/users/controllers/users.controller.ts

@@ -46,6 +46,11 @@ import {
 } from "../services";
 import { userAccountCreatedByAdminEmailSender } from "../../mails/services/templates-renderers";
 import { RegisterUserStructureAdminDto } from "../../portail-admin";
+import { AppLogsService } from "../../app-logs/app-logs.service";
+import {
+  UserStructureCreateLogContext,
+  UserStructureRoleChangeLogContext,
+} from "../../app-logs/app-log-context.types";
 
 const userProfile: UserProfile = "structure";
 
@@ -55,6 +60,7 @@ const userProfile: UserProfile = "structure";
 @AllowUserStructureRoles(...USER_STRUCTURE_ROLE_ALL)
 @UseGuards(AuthGuard("jwt"), AppUserGuard)
 export class UsersController {
+  constructor(private readonly appLogService: AppLogsService) {}
   @ApiBearerAuth()
   @ApiOperation({ summary: "Liste des utilisateurs" })
   @Get("")
@@ -118,13 +124,25 @@ export class UsersController {
     @Param("userUuid", new ParseUUIDPipe()) _userUuid: string,
     @CurrentChosenUserStructure() chosenUserStructure: UserStructure
   ): Promise<UserStructureProfile> {
+    const userToUpdate = await userStructureRepository.findOneBy({
+      uuid: chosenUserStructure.uuid,
+    });
     await userStructureRepository.update(
       {
         uuid: chosenUserStructure.uuid,
         structureId: userStructureAuth.structureId,
       },
       { role: updateRoleDto.role }
     );
+    await this.appLogService.create<UserStructureRoleChangeLogContext>({
+      action: "USER_ROLE_CHANGE",
+      context: {
+        newRole: updateRoleDto.role,
+        oldRole: userToUpdate.role,
+        userId: userToUpdate.id,
+        structureId: userToUpdate.structureId,
+      },
+    });
     return userStructureRepository.findOneBy({
       uuid: chosenUserStructure.uuid,
     });
@@ -200,6 +218,14 @@ export class UsersController {
       userId: chosenUserStructure.id,
       structureId: userStructureAuth.structureId,
     });
+    await this.appLogService.create<UserStructureCreateLogContext>({
+      action: "USER_DELETE",
+      context: {
+        role: chosenUserStructure.role,
+        userId: chosenUserStructure.id,
+        structureId: userStructureAuth.structureId,
+      },
+    });
 
     return res.status(HttpStatus.OK).json({ message: "OK" });
   }
@@ -266,7 +292,15 @@ export class UsersController {
           userProfile,
         })
         .then(
-          () => {
+          async () => {
+            await this.appLogService.create<UserStructureCreateLogContext>({
+              action: "USER_CREATE",
+              context: {
+                role: user.role,
+                userId: user.id,
+                structureId: user.structureId,
+              },
+            });
             return res.status(HttpStatus.OK).json({ message: "OK" });
           },
           () => {