fix(backend): add anon data for logs (#3875)

pYassine · web-flow · commit af56bb51deb9 · 2025-08-28T14:40:22.000+02:00
diff --git a/.kontinuous/env/dev/templates/backend.sealed-secret.yaml b/.kontinuous/env/dev/templates/backend.sealed-secret.yaml
@@ -15,7 +15,7 @@ spec:
     DOMIFA_MAIL_SMTP_TIPIMAIL_USER: >-
       AgC50XdpTvnpy7XLhDt6AqJDtpV5iKhg4pRnrQ3upidyOAyD4nLIxIExsuUCbAssC+SYg90qYtQWJ08cN6LeukOz2xOE8WDyzxOqK/B/XW9n2GnT66T8xaniuKfqkmKqFHolaxUCl6byYWjZlVwz8IbHb93CkwbVEAMe/3ZndDHzFikkvJJIA78NtFtAcOv/vuA/aR1qD/PfSCssxonfjqLmExhNCEKyKZrAOTuu91jzbOU3LqzOS0XAl2aPqyjqQzpAKnHINvJbaqbPLEqgS8nFenKjSTFjdHQVrHW8KL+mNHkw7Vcfn0yu3Az0QZxz/qoUWr85F6hz5f0B9s2nSYMvEORDh9hOahfQ432TnApbcuD9oKAK9k8OZD4uxVHtEhH/0NWYEXJf3eds7HICfiKDW3OuFq/FxzEHvJEeX2k9EyL5qhedDXdKM55/wAyWmM2wCx3Uvj4NxZrzajFy6Ssrq2YpsfDE4XWYkvzaMMXfzRCYEE1XWty+BdFlibwfPSMj2RoTKu2RxN6frIksbWDLNwGiRg+CW+FDQszszZO0WEBTvMLQ5/s/foselRxR3Z+T5qbd3w+WvtBJSQ/+JZZJ/VnzwJDvg3WdBD7EDGxjkgGsRp8B/KE2aaYpW3Rp5n6439zTHSMDVJFoqtaYK16ZsPIP51mZU5UHlpzy7d4is72YCRKu8ahq8iDXfB12V8HfNskGYX4H0tei4AFgqLWK36RA3Agc617KCTDDnLvb4Q==
     DOMIFA_MAIL_SMTP_TIPIMAIL_PASSWORD: >-
-      AgCqXU9dzG+RCr7AhZHXrph+s0Ij1H50uzBplnn2qk5o3WjrTjiB0tpgtPUH+uPqgC4oSOrHeWVssNgx+Aw8u4FeASBu+dYpq+UV8F7B4pK1Km6a0seBcAL819BIeiAMZWS5P2PpwLeXElW5GGhS/LBOKgE4C9KAU6RPV1GMi8ySHOexhHzYOu4MHevlNV7gnzdbTmeI8M5NwKw5UyJkWqEZ+A1KAdBduDTDhX5mzivgivXe6nsm/XbXPic/XLjYsROMfVyyLEbskeqV6cTOH7xMvPX4i5ee50keO95nUQdhZt4ldh+gIbe7wTIkaC9paflSqRjMMIb5kCvDuOhHjOIEwAYWXBkNZWjzr+ymAgoj9LZWgJm+i3B9XZOxvcxYbiwK8jlYjapYUoz2AT+ExdKAkSukusfW2qe2ZHsZdHYklZzzw8jXLbt0LrAt/QKaaWbEWIFk76iD+bpbiUP3t205jDU/9MSihBLa/uLiOG8Z93ZwNQ5fUkW1Nj6kZjmZAiwYTS7OXIOWAvwj4jfFNaeRq2s8mj4IYiGap9eax3UEC2bDUYLFWHOsGofG2Hypc8wfLurkUGgWXmrJq9v83P+6u9vTNlHvhIHz010SGaSKctFihWyuoQFVfHFG9gMWKnV3qHu0g3GlwbrturjYlKQf9dQSYqUedzl3Lh+DHlVcmpE+BpkSdnTE7dmtlEkfeASMmtQ5Z+3Z9TsJaf0B5y5no9mcYMm2vtGKY2WgR3pW4w==
+      AgB5GN2ae1OSDuiVndPqR9mWeyGXWRPiXBUr6/X9i7X4yvdHVk2WObtbPNW00MXwnzIAaC88a5SbWwwR2ciVlLNa926zCu8wECMlbCTnLTLqwZhPFCsk4D3vYFN2XdK3eXZ1Hdd2bLTFX1kQCz1jDS8/o+2x8+ceTXpKQwCVLO1VsDG49mctpDppp3CG4AxUY9BNg+S1DeuDiVVgLQFzWU/p4DfbQ7VgnQtEqskH30Nq9eJH0Cm6/cGNKat4OD9stdz4Vt8G6H3x2rlBmuLgCcJXX9t8jMc4lAYdW+VLIFTYPBRfH3xZ24T97ckGEolEs0jr5KnOXUEqf1DSByAqgXUebNIbgOEkGxMjVGQExPqE8uOIUy+JBQ3susE/nnFOSBglh0KAim3UYdvRmmdQyr6Z8MNrk5uuYRUsO6q0+EwV+5zEg1vXaMOLgiPw8q5jI/TznFc+PgTtFCUPxLwEnlFL9PWtL8VpwX0pXUDpP4ppcvDvQtw7SLA2ojgMaEWO05yWUDFiYUp+hNs+oG4kFBBPYE8VxNQNhq6L9JUtluHot6M+ySM2AZAX4ikZqB4XY7LLAcuQIN7fjHOgSoKRLNof+DIAFQQaDpU0L6mym6wzl/b9rjd+dfbu4es5Gyq58Q27J2Si1h3gpCf5vjg3b7YFqw5eukBH46pA2eV4vPDu8bhXbfUOJ/Z5djnAdmjzszIT+anXjUKvZaCh51WrJa0t8oXwt085GT2X/4rVzhi3CQ==
     DOMIFA_ERROR_REPORT_EMAILS: >-
       AgDGA3da8Ua+HCrJ48PpgF0GDSPtoNB42ninGpwCKlANgje0DsW4qjaQ2RHltt9ZFcPF07j/oLkXPGm1JwMlAodH38dDc39HjG8M1SIUQuG2+rS7AqlVqUtCYz/POhor+WOf+ZPI2Cy5ucREEGmZwHvjWm30KsckWYVTS4o9WOKaX11Xd0uqnvr4ADSbtKJp+wGiirwZPRMPFhYBrJIFYs1BwdQmxG3Ha++licqw9d3iPWgOeGJUCE1yQ9Jvfnvqa3hiGADEfM85UEv8yc3/VQAULXNo/hdjhu4evazmGsqLes+ondQIi0wKMIfPOFbruihYAIt7lAzxcSrrKC9yDr16b1Uv8wHpTu7dxrf6hMUePacJf9cihrAJEZuYe/YduLKE9YFPsC7tRfv/IJhGmRYZDGEDX+vDlgN+w4jMFJbarhOK+op3PXym1yzApzWng+UI8OEoCUjUWgqVKbQRy3uQivonCG1q6ytfNXcJviaTNwrZu8E65C/Xy5BmntNCe1JdFJv1QB8kolGPBovYQf1wdFLmZJ/z5dAs/qdnOhySp/Rp35shcEmor/3poCP2OqaNjjuiuOxJWOhaXY84YVnx5xhDB74qg/PU9n1xjACNqdsuJoWFVF0GSMwBJn3BLBfV/8OayS53vcUb1cQ/y/p0C03NEQMf/gHgVEu4KdWxBYfW6VhTrAN5myiXhu3j0CCAI4PhF31ADd5TRdJJ5wOWrZgXq2bJbU3MPy8ND2hoVHXTJZCRCNAgE+S4obwKfZ8Fl0AI7qclSKfYfA==
     DOMIFA_TIPIMAIL_FROM_EMAIL: >-
diff --git a/.talismanrc b/.talismanrc
@@ -2,7 +2,7 @@ fileignoreconfig:
 - filename: .anonymizer/yarn.lock
   checksum: adf574ab2b9fc5e21891b802504438b9f7738c8854047dbc7ca628cd3994ef5f
 - filename: .kontinuous/env/dev/templates/backend.sealed-secret.yaml
-  checksum: 029065f19d0c37b4e2de8dc5c29b7badc5823be28c63885470d2c363108eb5d2
+  checksum: eb02b7f4930980a6ad41118a3cae40e682d3322d1a3eba9b19b17da72e321136
 - filename: .kontinuous/env/preprod/templates/backend.sealed-secret.yaml
   checksum: 08602bd330f851a3a7a62707623f154cf4e33d43c96087b85531fee32dad342e
 - filename: _docs/dev/0.run-local-env.md
diff --git a/_scripts/db/dumps/domifa_test.postgres.custom.gz b/_scripts/db/dumps/domifa_test.postgres.custom.gz
diff --git a/packages/backend/src/_common/model/app-log/LogAction.type.ts b/packages/backend/src/_common/model/app-log/LogAction.type.ts
@@ -1,4 +1,9 @@
 export type LogAction =
+  | "USAGERS_DELETE"
+  | "USAGERS_PHONE_UPDATE"
+  | "USAGERS_PHONE_DELETE"
+  | "USAGERS_EMAIL_UPDATE"
+  | "USAGERS_EMAIL_DELETE"
   // Docs
   | "USAGERS_DOCS_UPLOAD"
   | "USAGERS_DOCS_DOWNLOAD"
@@ -48,7 +53,6 @@ export type LogAction =
   | "ADMIN_PASSWORD_RESET"
   // deprecated
   | "SUPPRIMER_PIECE_JOINTE"
-  | "SUPPRIMER_DOMICILIE"
   | "RESET_PASSWORD_PORTAIL"
   | "DOWNLOAD_PASSWORD_PORTAIL"
   | "DELETE_NOTE"
diff --git a/packages/backend/src/_migrations/1755523274895-auto-migration.ts b/packages/backend/src/_migrations/1755523274895-auto-migration.ts
@@ -6,12 +6,6 @@ export class AutoMigration1755523274895 implements MigrationInterface {
   public async up(queryRunner: QueryRunner): Promise<void> {
     console.log("🚀 Starting password type migration");
 
-    // Ajout de la colonne passwordType
-    await queryRunner.query(`
-      ALTER TABLE "user_usager"
-      ADD COLUMN "passwordType" text
-    `);
-
     // Initial stats
     const initialStats = await queryRunner.query(`
       SELECT
diff --git a/packages/backend/src/_migrations/1756117243337-manual-migration.ts b/packages/backend/src/_migrations/1756117243337-manual-migration.ts
@@ -0,0 +1,19 @@
+import { MigrationInterface, QueryRunner } from "typeorm";
+
+export class ManualMigration1756117243337 implements MigrationInterface {
+  public async up(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(`
+            UPDATE app_log
+            SET action = 'USAGER_DELETE'
+            WHERE action = 'SUPPRIMER_DOMICILIE'
+        `);
+  }
+
+  public async down(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(`
+            UPDATE app_log
+            SET action = 'SUPPRIMER_DOMICILIE'
+            WHERE action = 'USAGER_DELETE'
+        `);
+  }
+}
diff --git a/packages/backend/src/config/domifaConfig.service.ts b/packages/backend/src/config/domifaConfig.service.ts
@@ -10,8 +10,8 @@ import {
   DOMIFA_ENV_IDS,
 } from "./model";
 import { configParser } from "./services/configParser.service";
-import SMTPTransport = require("nodemailer/lib/smtp-transport");
 import { join } from "path";
+import SMTPTransport from "nodemailer/lib/smtp-transport";
 
 let _domifaConfig: DomifaConfig;
 
diff --git a/packages/backend/src/modules/mails/services/_core/smtpSender.service.ts b/packages/backend/src/modules/mails/services/_core/smtpSender.service.ts
@@ -2,7 +2,7 @@ import { HttpException, HttpStatus } from "@nestjs/common";
 import { createTransport, SendMailOptions } from "nodemailer";
 
 import { mailRecipientsFilter } from "./mailRecipientsFilter.service";
-import Mail = require("nodemailer/lib/mailer");
+
 import { domifaConfig } from "../../../../config";
 import {
   MessageEmailContent,
@@ -12,6 +12,7 @@ import {
   MessageEmailRecipient,
 } from "../../../../database";
 import { appLogger } from "../../../../util";
+import Mail from "nodemailer/lib/mailer";
 
 // create reusable transporter object using SMTP transport
 
@@ -96,6 +97,7 @@ async function sendEmail(
     };
     return sendDetails;
   } catch (err) {
+    console.log({ err });
     appLogger.warn(`[smtpSender] Error sending smtp message: : ${err}`, {
       sentry: true,
     });
diff --git a/packages/backend/src/open-telemetry.ts b/packages/backend/src/open-telemetry.ts
@@ -1,11 +1,9 @@
+import "@opentelemetry/api";
 import {
   SentrySpanProcessor,
   SentryPropagator,
 } from "@sentry/opentelemetry-node";
 
-import * as opentelemetry from "@opentelemetry/sdk-node";
-import "@opentelemetry/api";
-
 // Warning: don't use @opentelemetry/auto-instrumentations-node as it uses far too much memory at the start of the process
 import { HttpInstrumentation } from "@opentelemetry/instrumentation-http";
 import { ExpressInstrumentation } from "@opentelemetry/instrumentation-express";
@@ -19,6 +17,7 @@ import { domifaConfig } from "./config";
 import { appLogger } from "./util";
 import { format } from "date-fns";
 import { captureMessage, init } from "@sentry/node";
+import { NodeSDK } from "@opentelemetry/sdk-node";
 
 if (domifaConfig().dev.sentry.enabled) {
   init({
@@ -29,7 +28,7 @@ if (domifaConfig().dev.sentry.enabled) {
     profilesSampleRate: 1,
   });
 
-  const sdk = new opentelemetry.NodeSDK({
+  const sdk = new NodeSDK({
     traceExporter: new OTLPTraceExporter(),
     instrumentations: [
       new HttpInstrumentation(),
diff --git a/packages/backend/src/usagers/controllers/tests/usagers.controller.spec.ts b/packages/backend/src/usagers/controllers/tests/usagers.controller.spec.ts
@@ -17,6 +17,8 @@ import { UsagersService, UsagerOptionsHistoryService } from "../../services";
 import { UsagerHistoryStateService } from "../../services/usagerHistoryState.service";
 import { FileManagerService } from "../../../util/file-manager/file-manager.service";
 import { Usager } from "@domifa/common";
+import { UsagersLogsService } from "../../services/usagers-logs.service";
+import { AppLogsModule } from "../../../modules/app-logs/app-logs.module";
 
 const ENDPOINT = "/usagers";
 
@@ -37,13 +39,19 @@ describe("Usagers Controller", () => {
     context = await AppTestHelper.bootstrapTestApp(
       {
         controllers: [UsagersController],
-        imports: [UsagersModule, UsersModule, InteractionsModule],
+        imports: [
+          UsagersModule,
+          UsersModule,
+          InteractionsModule,
+          AppLogsModule,
+        ],
         providers: [
           UsagersService,
           UsagerOptionsHistoryService,
           AppLogsService,
           UsagerHistoryStateService,
           FileManagerService,
+          UsagersLogsService,
         ],
       },
       { initApp: true }
diff --git a/packages/backend/src/usagers/controllers/usager-options.controller.ts b/packages/backend/src/usagers/controllers/usager-options.controller.ts
@@ -33,7 +33,7 @@ import { UsagerOptionsHistoryService } from "../services";
 import { ExpressResponse } from "../../util/express";
 import { isEqual } from "lodash";
 
-import sortObj = require("sort-object");
+import * as sortObj from "sort-object";
 import { usagerRepository } from "../../database";
 import {
   Usager,
diff --git a/packages/backend/src/usagers/controllers/usagers.controller.ts b/packages/backend/src/usagers/controllers/usagers.controller.ts
@@ -34,7 +34,7 @@ import {
   USAGER_LIGHT_ATTRIBUTES,
 } from "../../database";
 
-import { cleanPath, getPhoneString } from "../../util";
+import { anonymizeFullName, cleanPath, getPhoneString } from "../../util";
 import {
   UserStructureAuthenticated,
   USER_STRUCTURE_ROLE_ALL,
@@ -49,8 +49,6 @@ import { UsagersService } from "../services";
 import { AppLogsService } from "../../modules/app-logs/app-logs.service";
 import { generateCerfaData } from "../utils/cerfa";
 
-import pdftk = require("node-pdftk");
-
 import { join, resolve } from "path";
 import { readFile } from "fs-extra";
 import { ExpressResponse } from "../../util/express";
@@ -60,6 +58,8 @@ import { domifaConfig } from "../../config";
 import { FileManagerService } from "../../util/file-manager/file-manager.service";
 import { AssignReferrersDto } from "../dto/assign-referrers.dto";
 import { In } from "typeorm";
+import { UsagersLogsService } from "../services/usagers-logs.service";
+import { input } from "node-pdftk";
 
 @Controller("usagers")
 @ApiTags("usagers")
@@ -72,7 +72,8 @@ export class UsagersController {
     private readonly usagersService: UsagersService,
     private readonly appLogsService: AppLogsService,
     private readonly usagerHistoryStateService: UsagerHistoryStateService,
-    private readonly fileManagerService: FileManagerService
+    private readonly fileManagerService: FileManagerService,
+    private readonly usagersLogsService: UsagersLogsService
   ) {}
 
   @Post()
@@ -107,6 +108,20 @@ export class UsagersController {
       { ...usagerDto }
     );
 
+    await this.usagersLogsService.checkAndLogEmailChanges(
+      currentUsager,
+      _user,
+      currentUsager?.email,
+      usagerDto?.email
+    );
+
+    await this.usagersLogsService.checkAndLogPhoneChanges(
+      currentUsager,
+      _user,
+      currentUsager?.telephone,
+      usagerDto?.telephone
+    );
+
     const createdAt = new Date();
     const historyBeginDate = createdAt;
 
@@ -140,6 +155,20 @@ export class UsagersController {
       email: contactDetails.email,
     };
 
+    await this.usagersLogsService.checkAndLogEmailChanges(
+      currentUsager,
+      _user,
+      currentUsager?.email,
+      contactDetails?.email
+    );
+
+    await this.usagersLogsService.checkAndLogPhoneChanges(
+      currentUsager,
+      _user,
+      currentUsager?.telephone,
+      contactDetails?.telephone
+    );
+
     await usagerRepository.update(
       { uuid: currentUsager.uuid },
       {
@@ -283,7 +312,13 @@ export class UsagersController {
       userId: user.id,
       usagerRef: usager.ref,
       structureId: user.structureId,
-      action: "SUPPRIMER_DOMICILIE",
+      action: "USAGERS_DELETE",
+      context: {
+        user: anonymizeFullName(user),
+        usagerNom: anonymizeFullName(usager),
+        usagerRef: usager.ref,
+        uuid: usager.uuid,
+      },
     });
 
     const key = `${join(
@@ -323,7 +358,7 @@ export class UsagersController {
     const filePath = await readFile(resolve(__dirname, pdfForm));
 
     try {
-      const buffer = await pdftk.input(filePath).fillForm(pdfInfos).output();
+      const buffer = await input(filePath).fillForm(pdfInfos).output();
       return res.setHeader("content-type", "application/pdf").send(buffer);
     } catch (err) {
       return res
diff --git a/packages/backend/src/usagers/services/tests/usagers-logs.service.spec.ts b/packages/backend/src/usagers/services/tests/usagers-logs.service.spec.ts
@@ -0,0 +1,27 @@
+import { UsagersLogsService } from "../usagers-logs.service";
+import { AppLogsService } from "../../../modules/app-logs/app-logs.service";
+import { forwardRef } from "@nestjs/common";
+import { UsersModule } from "../../../modules/users/users.module";
+import { AppTestContext, AppTestHelper } from "../../../util/test";
+import { UsagerHistoryStateService } from "../usagerHistoryState.service";
+import { UsagersService } from "../usagers.service";
+
+describe("UsagersLogsService", () => {
+  let service: UsagersLogsService;
+  let context: AppTestContext;
+
+  beforeAll(async () => {
+    context = await AppTestHelper.bootstrapTestApp({
+      imports: [forwardRef(() => UsersModule)],
+      providers: [UsagersService, UsagerHistoryStateService, AppLogsService],
+    });
+    service = context.module.get<UsagersLogsService>(UsagersLogsService);
+  });
+  afterAll(async () => {
+    await AppTestHelper.tearDownTestApp(context);
+  });
+
+  it("should be defined", () => {
+    expect(service).toBeDefined();
+  });
+});
diff --git a/packages/backend/src/usagers/services/tests/usagers.service.spec.ts b/packages/backend/src/usagers/services/tests/usagers.service.spec.ts
@@ -11,6 +11,8 @@ import { UsagersService } from "../usagers.service";
 
 import { UsagerHistoryStateService } from "../usagerHistoryState.service";
 import { UserStructure } from "@domifa/common";
+import { UsagersLogsService } from "../usagers-logs.service";
+import { AppLogsModule } from "../../../modules/app-logs/app-logs.module";
 
 describe("UsagersService", () => {
   let service: UsagersService;
@@ -33,8 +35,12 @@ describe("UsagersService", () => {
 
   beforeAll(async () => {
     context = await AppTestHelper.bootstrapTestApp({
-      imports: [forwardRef(() => UsersModule)],
-      providers: [UsagersService, UsagerHistoryStateService],
+      imports: [forwardRef(() => UsersModule), AppLogsModule],
+      providers: [
+        UsagersService,
+        UsagerHistoryStateService,
+        UsagersLogsService,
+      ],
     });
     service = context.module.get<UsagersService>(UsagersService);
   });
diff --git a/packages/backend/src/usagers/services/usagers-logs.service.ts b/packages/backend/src/usagers/services/usagers-logs.service.ts
diff --git a/packages/backend/src/usagers/usagers.module.ts b/packages/backend/src/usagers/usagers.module.ts
diff --git a/packages/backend/src/util/functions/anonymizeFullName.spec.ts b/packages/backend/src/util/functions/anonymizeFullName.spec.ts
diff --git a/packages/backend/src/util/functions/anonymizeFullName.ts b/packages/backend/src/util/functions/anonymizeFullName.ts
diff --git a/packages/backend/src/util/functions/index.ts b/packages/backend/src/util/functions/index.ts
