fix(backend): fix reviews

Author: hbalty

packages/backend/src/_migrations/1756117243336-manual-migration.ts

@@ -0,0 +1,27 @@
+import { MigrationInterface, QueryRunner } from "typeorm";
+
+export class ManualMigration1756117243336 implements MigrationInterface {
+  public async up(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(`
+      UPDATE "app_log"
+      SET action = CASE
+        WHEN action = 'DOWNLOAD_IMPORT_GUIDE' THEN 'IMPORT_DOWNLOAD_GUIDE'
+        WHEN action = 'DOWNLOAD_IMPORT_TEMPLATE' THEN 'IMPORT_TEMPLATE_DOWNLOAD'
+        ELSE action
+      END
+      WHERE action IN ('DOWNLOAD_IMPORT_GUIDE', 'DOWNLOAD_IMPORT_TEMPLATE');
+    `);
+  }
+
+  public async down(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(`
+      UPDATE "app_log"
+      SET action = CASE
+        WHEN action = 'IMPORT_DOWNLOAD_GUIDE' THEN 'DOWNLOAD_IMPORT_GUIDE'
+        WHEN action = 'IMPORT_TEMPLATE_DOWNLOAD' THEN 'DOWNLOAD_IMPORT_TEMPLATE'
+        ELSE action
+      END
+      WHERE action IN ('IMPORT_DOWNLOAD_GUIDE', 'IMPORT_TEMPLATE_DOWNLOAD');
+    `);
+  }
+}

packages/backend/src/usagers/controllers/import/import.controller.spec.ts

@@ -74,7 +74,12 @@ describe("Import Controller", () => {
 
     expect(response.status).toBe(HttpStatus.BAD_REQUEST);
 
-    const logs = await appLogsRepository.find({});
+    const logs = await appLogsRepository.find({
+      where: {
+        userId: authInfo.id,
+        structureId: authInfo.structureId,
+      },
+    });
     expect(logs.length).toBe(1);
     expect(logs[0].action).toBe("IMPORT_USAGERS_FAILED");
     expect(logs[0].context).toEqual({
@@ -108,7 +113,12 @@ describe("Import Controller", () => {
       },
     });
 
-    const logs = await appLogsRepository.find({});
+    const logs = await appLogsRepository.find({
+      where: {
+        userId: authInfo.id,
+        structureId: authInfo.structureId,
+      },
+    });
     expect(logs.length).toBe(1);
     expect(logs[0].action).toBe("IMPORT_USAGERS_SUCCESS");
     expect(logs[0].context).toEqual({
@@ -140,7 +150,12 @@ describe("Import Controller", () => {
       },
     });
 
-    const logs = await appLogsRepository.find({});
+    const logs = await appLogsRepository.find({
+      where: {
+        userId: authInfo.id,
+        structureId: authInfo.structureId,
+      },
+    });
     expect(logs.length).toBe(1);
     expect(logs[0].action).toBe("IMPORT_USAGERS_SUCCESS");
     expect(logs[0].context).toEqual({

packages/backend/src/usagers/controllers/import/import.controller.ts

@@ -320,21 +320,15 @@ export class ImportController {
     @Param("documentType", new ParseEnumPipe(ImportDocumentType))
     documentType: ImportDocumentType
   ) {
-    if (documentType === ImportDocumentType.GUIDE)
-      await this.appLogsService.create({
-        role: user.role,
-        structureId: user.structureId,
-        userId: user.id,
-        action: "IMPORT_DOWNLOAD_GUIDE",
-      });
-
-    if (documentType === ImportDocumentType.MODELE)
-      await this.appLogsService.create({
-        role: user.role,
-        structureId: user.structureId,
-        userId: user.id,
-        action: "IMPORT_TEMPLATE_DOWNLOAD",
-      });
+    await this.appLogsService.create({
+      role: user.role,
+      structureId: user.structureId,
+      userId: user.id,
+      action:
+        documentType === ImportDocumentType.GUIDE
+          ? "IMPORT_DOWNLOAD_GUIDE"
+          : "IMPORT_TEMPLATE_DOWNLOAD",
+    });
   }
 }