fix(backend): fix add referrer at creation step

Author: pYassine

packages/backend/src/usagers/controllers/security-tests/usagers.controller.security-tests.ts

@@ -4,6 +4,7 @@ import {
   AppTestHttpClientSecurityTestDef,
   expectedResponseStatusBuilder,
 } from "../../../_tests";
+import CREATE_USAGER_DTO from "../../services/tests/CREATE_USAGER_DTO.const";
 
 ////////////////// IMPORTANT //////////////////
 //
@@ -37,4 +38,24 @@ export const UsagersControllerSecurityTests: AppTestHttpClientSecurityTestDef[]
         ),
       }),
     },
+    {
+      label: `${CONTROLLER}.createUsager`,
+      query: async (context: AppTestContext) => ({
+        response: await AppTestHttpClient.post("/usagers", {
+          context,
+          body: {
+            ...CREATE_USAGER_DTO,
+            referrerId: 10000, // Fake referrerId
+          },
+        }),
+        expectedStatus: expectedResponseStatusBuilder.allowStructureOnly(
+          context.user,
+          {
+            validExpectedResponseStatus: HttpStatus.BAD_REQUEST,
+            invalidStructureIdExpectedResponseStatus: HttpStatus.BAD_REQUEST,
+            roles: ["simple", "responsable", "admin"],
+          }
+        ),
+      }),
+    },
   ];

packages/backend/src/usagers/controllers/tests/usagers.controller.spec.ts

@@ -153,6 +153,16 @@ describe("Usagers Controller", () => {
       expect(responseDelete.body).toBeDefined();
     });
 
+    it("❌ Référent qui n'existe pas", async () => {
+      const response = await AppTestHttpClient.post(ENDPOINT, {
+        context,
+        body: { ...POST_USAGER.payload, referrerId: 1000292 },
+      });
+
+      expect(response.status).toBe(400);
+      expect(response.body).toBeDefined();
+      expect(response.body?.message).toEqual("CANNOT_FIND_REFERRER");
+    });
     it("❌ Données manquantes", async () => {
       const NOT_OK = { ...POST_USAGER.payload };
       delete NOT_OK.prenom;

packages/backend/src/usagers/services/tests/CREATE_USAGER_DTO.const.ts

@@ -0,0 +1,16 @@
+import { CreateUsagerDto } from "../../dto/decision-form/create-usager.dto";
+
+const CREATE_USAGER_DTO = new CreateUsagerDto();
+CREATE_USAGER_DTO.nom = "Usager";
+CREATE_USAGER_DTO.prenom = "De test";
+CREATE_USAGER_DTO.surnom = "Chips";
+CREATE_USAGER_DTO.sexe = "homme";
+CREATE_USAGER_DTO.dateNaissance = new Date();
+CREATE_USAGER_DTO.villeNaissance = "Paris";
+CREATE_USAGER_DTO.email = "chips@gmail.com";
+CREATE_USAGER_DTO.telephone = {
+  countryCode: "fr",
+  numero: "",
+};
+
+export default CREATE_USAGER_DTO;

packages/backend/src/usagers/services/tests/usagers.service.spec.ts

@@ -6,31 +6,16 @@ import {
 } from "../../../database";
 import { UsersModule } from "../../../modules/users/users.module";
 import { AppTestContext, AppTestHelper } from "../../../util/test";
-import { CreateUsagerDto } from "../../dto";
 import { UsagersService } from "../usagers.service";
 
 import { UsagerHistoryStateService } from "../usagerHistoryState.service";
 import { UserStructure } from "@domifa/common";
 import { UsagersLogsService } from "../usagers-logs.service";
 import { AppLogsModule } from "../../../modules/app-logs/app-logs.module";
+import CREATE_USAGER_DTO from "./CREATE_USAGER_DTO.const";
 
 describe("UsagersService", () => {
   let service: UsagersService;
-
-  const fakeUsagerDto = new CreateUsagerDto();
-
-  fakeUsagerDto.nom = "Usager";
-  fakeUsagerDto.prenom = "De test";
-  fakeUsagerDto.surnom = "Chips";
-  fakeUsagerDto.sexe = "homme";
-  fakeUsagerDto.dateNaissance = new Date();
-  fakeUsagerDto.villeNaissance = "Paris";
-  fakeUsagerDto.email = "chips@gmail.com";
-  fakeUsagerDto.telephone = {
-    countryCode: "fr",
-    numero: null,
-  };
-
   let context: AppTestContext;
 
   beforeAll(async () => {
@@ -58,7 +43,7 @@ describe("UsagersService", () => {
     })) as UserStructure;
     user.structure = await structureRepository.findOneBy({ id: 5 });
 
-    const usagerTest = await service.create(fakeUsagerDto, user);
+    const usagerTest = await service.create(CREATE_USAGER_DTO, user);
 
     expect(usagerTest).toBeDefined();
 
@@ -68,8 +53,8 @@ describe("UsagersService", () => {
       structureId: user.structureId,
     });
     expect(usager).toBeTruthy();
-    expect(usager.nom).toEqual(fakeUsagerDto.nom);
-    expect(usager.sexe).toEqual(fakeUsagerDto.sexe);
+    expect(usager.nom).toEqual(CREATE_USAGER_DTO.nom);
+    expect(usager.sexe).toEqual(CREATE_USAGER_DTO.sexe);
 
     await usagerRepository.delete({ uuid: usager.uuid });