fix(backend): adding userId and structureId to user create log

Author: hbalty

packages/backend/src/modules/users/controllers/users.controller.spec.ts

@@ -13,32 +13,24 @@ import {
 } from "../../../util/test";
 import { UsersController } from "./users.controller";
 import { POST_USER_STRUCTURE_BODY } from "../../../_common/mocks";
-import { TESTS_USERS_STRUCTURE } from "../../../_tests";
+import { TESTS_USERS_STRUCTURE, TestUserStructure } from "../../../_tests";
 import { usersDeletor } from "../services/users-deletor.service";
 import { MailsModule } from "../../mails/mails.module";
 import { AppLogsService } from "../../app-logs/app-logs.service";
-import { userStructureRepository } from "../../../database";
+import { appLogsRepository } from "../../../database";
 
 describe("Users Controller", () => {
   let controller: UsersController;
   let context: AppTestContext;
-  let appLogService: AppLogsService;
+  let authInfo: TestUserStructure;
   beforeAll(async () => {
-    appLogService = {
-      create: jest.fn(),
-    };
     context = await AppTestHelper.bootstrapTestApp({
       controllers: [UsersController],
       imports: [MailsModule, StructuresModule, UsagersModule, HttpModule],
-      providers: [
-        {
-          provide: AppLogsService,
-          useValue: appLogService,
-        },
-      ],
+      providers: [AppLogsService],
     });
 
-    const authInfo =
+    authInfo =
       TESTS_USERS_STRUCTURE.BY_EMAIL["preprod.domifa@fabrique.social.gouv.fr"];
     await AppTestHelper.authenticateStructure(authInfo, { context });
     controller = context.module.get<UsersController>(UsersController);
@@ -49,6 +41,10 @@ describe("Users Controller", () => {
     await AppTestHelper.tearDownTestApp(context);
   });
 
+  beforeEach(async () => {
+    await appLogsRepository.clear();
+  });
+
   describe("> Register user", () => {
     describe("Nominal case", () => {
       it("should be defined", async () => {
@@ -65,19 +61,16 @@ describe("Users Controller", () => {
             structure: { ...POST_USER_STRUCTURE_BODY.structure, id: 1 },
           },
         });
-
-        const user = await userStructureRepository.findOneByOrFail({
-          email: "test@test.com",
-        });
-        expect(appLogService.create).toHaveBeenCalledWith({
-          action: "USER_CREATE",
-          userId: context.user.userId,
-          context: {
-            role: POST_USER_STRUCTURE_BODY.role,
-            structureId: 1,
-            userId: user.id,
+        const logs = await appLogsRepository.find({
+          where: {
+            userId: authInfo.id,
+            action: "USER_CREATE",
           },
         });
+        expect(logs.length).toEqual(1);
+        expect(logs[0].action).toEqual("USER_CREATE");
+        expect(logs[0].role).toEqual(authInfo.role);
+        expect(logs[0].userId).toEqual(authInfo.id);
         expect(response.status).toBe(200);
         expect(response.text).toBe('{"message":"OK"}');
       });

packages/backend/src/modules/users/controllers/users.controller.ts

@@ -299,6 +299,8 @@ export class UsersController {
             await this.appLogService.create<UserStructureCreateLogContext>({
               action: "USER_CREATE",
               userId: user.id,
+              structureId: "structureId" in user ? user.structureId : null,
+              role: user.role,
               context: {
                 role: newUser.role,
                 userId: newUser.id,