Skip to content

Conversation

pYassine
Copy link
Contributor

No description provided.

@pYassine pYassine marked this pull request as ready for review November 22, 2024 00:08
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
1 Security Hotspot
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

Copy link

🎉 Deployment for commit 97166bd :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-97166bd806c439923cda0c0cc635b19c2b49c13f
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-97166bd806c439923cda0c0cc635b19c2b49c13f
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-97166bd806c439923cda0c0cc635b19c2b49c13f
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-97166bd806c439923cda0c0cc635b19c2b49c13f
Debug

@codecov-commenter
Copy link

codecov-commenter commented Nov 22, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 79.48718% with 64 lines in your changes missing coverage. Please review.

Project coverage is 66.68%. Comparing base (1729c4d) to head (97166bd).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
...rc/modules/open-data-places/load-data-inclusion.ts 0.00% 6 Missing ⚠️
...s/backend/src/modules/open-data-places/load-mss.ts 0.00% 6 Missing ⚠️
...end/src/modules/open-data-places/load-soliguide.ts 0.00% 5 Missing ⚠️
...ge-usagers-table/manage-usagers-table.component.ts 50.00% 4 Missing and 1 partial ⚠️
...ackend/src/modules/open-data-places/load-domifa.ts 0.00% 4 Missing ⚠️
...rc/structures/controllers/structures.controller.ts 33.33% 4 Missing ⚠️
...ils-senders/cron-mail-user-guide-sender.service.ts 57.14% 3 Missing ⚠️
packages/backend/src/run-app.ts 0.00% 3 Missing ⚠️
...nd/src/usagers/services/cerfa/get-decision-date.ts 89.28% 3 Missing ⚠️
...e/services/monitoring/MonitoringCleaner.service.ts 33.33% 2 Missing ⚠️
... and 18 more

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3566      +/-   ##
==========================================
+ Coverage   66.67%   66.68%   +0.01%     
==========================================
  Files         909      917       +8     
  Lines       15080    15092      +12     
  Branches     2133     2127       -6     
==========================================
+ Hits        10054    10064      +10     
+ Misses       4850     4723     -127     
- Partials      176      305     +129     
Files with missing lines Coverage Δ
packages/backend/src/_common/model/usager/index.ts 100.00% <ø> (ø)
...I_SECURITY_STRUCTURE_CONTROLLER_TEST_DEFS.const.ts 100.00% <100.00%> (ø)
packages/backend/src/app.module.ts 100.00% <100.00%> (ø)
...rc/database/entities/usager/UsagerTable.typeorm.ts 100.00% <ø> (ø)
...ules/contact-support/contact-support.controller.ts 37.03% <100.00%> (-2.25%) ⬇️
...ages/backend/src/modules/interactions/dto/index.ts 100.00% <ø> (ø)
...d/src/modules/interactions/dto/interactions.dto.ts 85.00% <100.00%> (ø)
...ractions/interactions.controller.security-tests.ts 100.00% <100.00%> (ø)
...rc/modules/interactions/interactions.controller.ts 67.56% <100.00%> (ø)
...nd/src/modules/interactions/interactions.module.ts 100.00% <100.00%> (ø)
... and 135 more

... and 59 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1729c4d...97166bd. Read the comment docs.

---- 🚨 Try these New Features:

@pYassine pYassine merged commit dbe1c90 into master Nov 22, 2024
11 of 12 checks passed
@pYassine pYassine deleted the feat-add-select-multiple branch November 22, 2024 13:17
@SocialGroovyBot
Copy link
Member

🎉 This PR is included in version 2.185.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants