Skip to content

Conversation

pYassine
Copy link
Contributor

No description provided.

@pYassine pYassine marked this pull request as ready for review May 16, 2025 08:47
@pYassine pYassine force-pushed the fix-register-user branch from 14ef9a6 to bbeca61 Compare May 16, 2025 08:47
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
38.8% Duplication on New Code (required ≤ 15%)

See analysis details on SonarQube Cloud

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 33.33333% with 10 lines in your changes missing coverage. Please review.

Project coverage is 65.52%. Comparing base (6a9f6f5) to head (451d3c4).

Files with missing lines Patch % Lines
...gister-user-admin/register-user-admin.component.ts 10.00% 9 Missing ⚠️
...ages/backend/src/auth/guards/AppUserGuard.guard.ts 80.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3722      +/-   ##
==========================================
- Coverage   65.54%   65.52%   -0.02%     
==========================================
  Files         958      958              
  Lines       15921    15925       +4     
  Branches     2204     2206       +2     
==========================================
  Hits        10435    10435              
- Misses       5146     5283     +137     
+ Partials      340      207     -133     
Files with missing lines Coverage Δ
...ages/backend/src/auth/guards/AppUserGuard.guard.ts 94.91% <80.00%> (-1.45%) ⬇️
...gister-user-admin/register-user-admin.component.ts 56.86% <10.00%> (ø)

... and 60 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6a9f6f5...451d3c4. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pYassine pYassine merged commit 5d8a334 into master May 16, 2025
12 of 14 checks passed
@pYassine pYassine deleted the fix-register-user branch May 16, 2025 09:16
@tokenbureau
Copy link

tokenbureau bot commented May 16, 2025

🎉 This PR is included in version 2.201.7 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tokenbureau tokenbureau bot added the released label May 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants