Skip to content

Conversation

hbalty
Copy link
Contributor

@hbalty hbalty commented Jul 29, 2025

No description provided.

@revu-bot revu-bot bot requested a review from revu-bot July 29, 2025 16:23
@hbalty hbalty force-pushed the feat-log-admins-activity branch from 37502be to 5cc3f98 Compare August 1, 2025 12:17
@hbalty hbalty temporarily deployed to build-review-auto August 1, 2025 12:17 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 1, 2025 12:17 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 1, 2025 12:17 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 1, 2025 12:17 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 1, 2025 14:09 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 1, 2025 14:09 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 1, 2025 14:09 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 1, 2025 14:09 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 69.23077% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.89%. Comparing base (fde37d4) to head (92157bd).
⚠️ Report is 15 commits behind head on master.

Files with missing lines Patch % Lines
.../controllers/admin-users/admin-users.controller.ts 25.00% 5 Missing and 1 partial ⚠️
...s/users/controllers/users-supervisor.controller.ts 60.00% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #3824    +/-   ##
========================================
  Coverage   65.88%   65.89%            
========================================
  Files         964      965     +1     
  Lines       16196    16217    +21     
  Branches     2250     2252     +2     
========================================
+ Hits        10671    10686    +15     
+ Misses       5476     5189   -287     
- Partials       49      342   +293     
Files with missing lines Coverage Δ
...rc/auth/decorators/current-supervisor.decorator.ts 100.00% <100.00%> (ø)
...tures-delete/admin-structures-delete.controller.ts 75.51% <100.00%> (+2.17%) ⬆️
...rs/admin-structures/admin-structures.controller.ts 70.21% <100.00%> (+1.32%) ⬆️
...ices/userSecurityResetPasswordInitiator.service.ts 96.15% <ø> (ø)
packages/backend/src/modules/users/users.module.ts 100.00% <100.00%> (ø)
...s/users/controllers/users-supervisor.controller.ts 45.45% <60.00%> (+2.59%) ⬆️
.../controllers/admin-users/admin-users.controller.ts 48.64% <25.00%> (-2.78%) ⬇️

... and 127 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fde37d4...92157bd. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hbalty hbalty force-pushed the feat-log-admins-activity branch from 84adc28 to bdee0aa Compare August 1, 2025 15:21
@hbalty hbalty temporarily deployed to build-review-auto August 1, 2025 15:21 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 1, 2025 15:21 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 1, 2025 15:21 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 1, 2025 15:21 — with GitHub Actions Inactive
@hbalty hbalty marked this pull request as ready for review August 1, 2025 15:47
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds comprehensive admin activity logging across structure and user management operations. The implementation is generally solid with proper type definitions and consistent logging patterns. However, there are several critical issues: missing context data in some log entries, inconsistent error handling, and a potential bug in the role elevation logic. The test coverage improvements are good, but some logging calls could be more informative.

@hbalty hbalty temporarily deployed to build-review-auto August 4, 2025 13:13 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 15:47 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 15:47 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 15:47 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 15:47 — with GitHub Actions Inactive
@hbalty hbalty requested a review from pYassine August 8, 2025 15:49
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 16:22 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 16:22 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 16:22 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 16:22 — with GitHub Actions Inactive
@hbalty hbalty force-pushed the feat-log-admins-activity branch from 090a028 to fe140e7 Compare August 8, 2025 16:26
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 16:26 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 16:26 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 16:26 — with GitHub Actions Inactive
@hbalty hbalty force-pushed the feat-log-admins-activity branch from fe140e7 to 92157bd Compare August 8, 2025 16:27
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 16:27 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 16:27 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 16:27 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 16:27 — with GitHub Actions Inactive
Copy link

sonarqubecloud bot commented Aug 8, 2025

Quality Gate Failed Quality Gate failed

Failed conditions
C Reliability Rating on New Code (required ≥ A)

See analysis details on SonarQube Cloud

Catch issues before they fail your Quality Gate with our IDE extension SonarQube for IDE

@tokenbureau
Copy link

tokenbureau bot commented Aug 8, 2025

🎉 Deployment for commit 92157bd :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-92157bd31dfe6e5cc3d6ec499587c23f6b798a97
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-92157bd31dfe6e5cc3d6ec499587c23f6b798a97
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-92157bd31dfe6e5cc3d6ec499587c23f6b798a97
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-92157bd31dfe6e5cc3d6ec499587c23f6b798a97
Debug

@pYassine pYassine merged commit 66753d2 into master Aug 9, 2025
18 of 19 checks passed
@pYassine pYassine deleted the feat-log-admins-activity branch August 9, 2025 16:30
@tokenbureau
Copy link

tokenbureau bot commented Aug 9, 2025

🎉 This PR is included in version 2.212.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tokenbureau tokenbureau bot added the released label Aug 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants