-
Notifications
You must be signed in to change notification settings - Fork 10
Feat: log admins activity #3824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
37502be
to
5cc3f98
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3824 +/- ##
========================================
Coverage 65.88% 65.89%
========================================
Files 964 965 +1
Lines 16196 16217 +21
Branches 2250 2252 +2
========================================
+ Hits 10671 10686 +15
+ Misses 5476 5189 -287
- Partials 49 342 +293
... and 127 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
84adc28
to
bdee0aa
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds comprehensive admin activity logging across structure and user management operations. The implementation is generally solid with proper type definitions and consistent logging patterns. However, there are several critical issues: missing context data in some log entries, inconsistent error handling, and a potential bug in the role elevation logic. The test coverage improvements are good, but some logging calls could be more informative.
packages/backend/src/modules/portail-admin/controllers/admin-users/admin-users.controller.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/modules/portail-admin/controllers/admin-users/admin-users.controller.ts
Show resolved
Hide resolved
packages/backend/src/modules/users/controllers/users-supervisor.controller.ts
Show resolved
Hide resolved
packages/backend/src/modules/portail-admin/controllers/admin-users/admin-users.controller.ts
Outdated
Show resolved
Hide resolved
...ules/portail-admin/controllers/admin-structures-delete/admin-structures-delete.controller.ts
Outdated
Show resolved
Hide resolved
090a028
to
fe140e7
Compare
fe140e7
to
92157bd
Compare
|
🎉 This PR is included in version 2.212.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.