Skip to content

Conversation

hbalty
Copy link
Contributor

@hbalty hbalty commented Aug 8, 2025

No description provided.

@revu-bot revu-bot bot requested a review from revu-bot August 8, 2025 09:24
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occurred: ## ⚠️ PR Review Skipped

Issues Found

1. This PR changes 57 files, which exceeds the limit of 25 files.

Suggestion: Consider breaking this PR into smaller, more focused changes. Large PRs are harder to review effectively and may contain unrelated changes.

2. This PR contains files that exceed the size limit: 'yarn.lock' (3852 lines of changes), which exceeds the limit of 2000. The limit is 2000 lines per file.

Suggestion: Consider refactoring large changes into smaller, more focused modifications. Large file changes are harder to review and understand.

PR Metrics

  • Total files changed: 57
  • Reviewable files: 57
  • Diff size: 5025 lines
  • Documentation files: 0
  • Largest file change: 3852 lines
  • Addition/Deletion ratio: 13.38

This validation helps ensure the bot focuses on PRs where automated review provides the most value. You can adjust these limits in your .revu.yml configuration file.

Revu logs

@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 09:39 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 09:39 — with GitHub Actions Inactive
@hbalty hbalty had a problem deploying to build-review-auto August 8, 2025 09:39 — with GitHub Actions Failure
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 09:39 — with GitHub Actions Inactive
@hbalty hbalty force-pushed the feat-migrating-portail-usagers-core-v18 branch from eeac3ae to f7184c9 Compare August 8, 2025 09:46
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 09:46 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 09:46 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 09:46 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 8, 2025 09:46 — with GitHub Actions Inactive
Copy link

socket-security bot commented Aug 8, 2025

@codecov-commenter
Copy link

codecov-commenter commented Aug 8, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.93%. Comparing base (39fdf9c) to head (beb6e1c).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3840      +/-   ##
==========================================
- Coverage   65.93%   65.93%   -0.01%     
==========================================
  Files         971      971              
  Lines       16256    16255       -1     
  Branches     2247     2251       +4     
==========================================
- Hits        10719    10717       -2     
- Misses       5191     5194       +3     
+ Partials      346      344       -2     
Files with missing lines Coverage Δ
packages/frontend/src/app/app.component.html 100.00% <ø> (ø)
packages/frontend/src/app/app.module.ts 93.33% <100.00%> (ø)
...mation/manage-structure-information.component.html 100.00% <ø> (ø)
...agers-params/portail-usagers-params.component.html 100.00% <ø> (ø)
...nts/contact-support/contact-support.component.html 100.00% <ø> (ø)
...ules/general/components/login/login.component.html 100.00% <ø> (ø)
...s/mentions-legales/mentions-legales.component.html 100.00% <ø> (ø)
...ts/static-pages/politique/politique.component.html 100.00% <ø> (ø)
...frontend/src/app/modules/general/general.module.ts 100.00% <100.00%> (ø)
...s/assign-referrers/assign-referrers.component.html 100.00% <ø> (ø)
... and 50 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39fdf9c...beb6e1c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hbalty hbalty changed the title Feat migrating portail usagers core v18 Feat migrating portail structure core v18 Aug 11, 2025
@hbalty hbalty temporarily deployed to build-review-auto August 11, 2025 20:30 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 11, 2025 20:30 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 11, 2025 20:30 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 11, 2025 20:30 — with GitHub Actions Inactive
@hbalty hbalty force-pushed the feat-migrating-portail-usagers-core-v18 branch from 7a6bf34 to 68bc56d Compare August 12, 2025 10:59
@hbalty hbalty temporarily deployed to build-review-auto August 12, 2025 10:59 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 12, 2025 10:59 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 12, 2025 10:59 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 12, 2025 10:59 — with GitHub Actions Inactive
Copy link
Contributor

@pYassine pYassine left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Est-ce qu'on ne fait pas l'update des fichiers de testing ?
HttpClientTestingModule est aussi deprecated. Comme ça nos tests & components sont raccords

@hbalty hbalty temporarily deployed to build-review-auto August 14, 2025 15:18 — with GitHub Actions Inactive
@pYassine pYassine force-pushed the feat-migrating-portail-usagers-core-v18 branch from b751fb1 to 4328a45 Compare August 18, 2025 17:46
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 17:46 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 17:46 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 17:46 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 17:46 — with GitHub Actions Inactive
Copy link

socket-security bot commented Aug 18, 2025

All alerts resolved. Learn more about Socket for GitHub.

This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored.

View full report

@tokenbureau
Copy link

tokenbureau bot commented Aug 18, 2025

🎉 Deployment for commit 4328a45 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-4328a45554f82b3c1a2d732337b4964c689f7a98
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-4328a45554f82b3c1a2d732337b4964c689f7a98
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-4328a45554f82b3c1a2d732337b4964c689f7a98
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-4328a45554f82b3c1a2d732337b4964c689f7a98
Debug

@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 23:28 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 23:28 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 23:28 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 23:28 — with GitHub Actions Inactive
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
21.4% Duplication on New Code (required ≤ 15%)

See analysis details on SonarQube Cloud

@pYassine pYassine merged commit 76a1743 into master Aug 18, 2025
17 of 19 checks passed
@pYassine pYassine deleted the feat-migrating-portail-usagers-core-v18 branch August 18, 2025 23:40
@tokenbureau
Copy link

tokenbureau bot commented Aug 18, 2025

🎉 This PR is included in version 2.218.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tokenbureau tokenbureau bot added the released label Aug 18, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants