Skip to content

Conversation

hbalty
Copy link
Contributor

@hbalty hbalty commented Aug 11, 2025

No description provided.

@revu-bot revu-bot bot requested a review from revu-bot August 11, 2025 13:09
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds structureId and role fields to import logging, which improves audit trail capabilities. The changes are consistent across both the controller and test files. However, there's a critical bug in the controller where these fields are missing from one of the log creation calls, and the test coverage reveals some inconsistencies in the expected log structure.

@hbalty hbalty temporarily deployed to build-review-auto August 11, 2025 13:35 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 11, 2025 13:35 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 11, 2025 13:35 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 11, 2025 13:35 — with GitHub Actions Inactive
Copy link

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.70%. Comparing base (177fb1f) to head (4d443ae).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #3848   +/-   ##
=======================================
  Coverage   65.70%   65.70%           
=======================================
  Files         970      970           
  Lines       16238    16238           
  Branches     2245     2237    -8     
=======================================
  Hits        10669    10669           
  Misses       5224     5224           
  Partials      345      345           
Files with missing lines Coverage Δ
...rc/usagers/controllers/import/import.controller.ts 87.87% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 177fb1f...4d443ae. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tokenbureau
Copy link

tokenbureau bot commented Aug 11, 2025

🎉 Deployment for commit 4d443ae :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-4d443aede4119e84ada185fd6be31402e2e7165a
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-4d443aede4119e84ada185fd6be31402e2e7165a
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-4d443aede4119e84ada185fd6be31402e2e7165a
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-4d443aede4119e84ada185fd6be31402e2e7165a
Debug

@pYassine pYassine merged commit 7385194 into master Aug 11, 2025
19 checks passed
@pYassine pYassine deleted the fix-log-import branch August 11, 2025 15:09
@tokenbureau
Copy link

tokenbureau bot commented Aug 11, 2025

🎉 This PR is included in version 2.212.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tokenbureau tokenbureau bot added the released label Aug 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants