Skip to content

fix(back): ajout de la structureId et le role aux logs d'import #3848

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 11, 2025
Merged

fix(back): ajout de la structureId et le role aux logs d'import #3848

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f2e88ae
fix(back): ajout de la structureId et le role aux logs d'import
hbalty Aug 11, 2025
4d443ae
fix(tests): clearing mocks after each test case
hbalty Aug 11, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions packages/backend/src/usagers/controllers/import/import.controller.spec.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,6 +58,10 @@ describe("Import Controller", () => {
controller = context.module.get<ImportController>(ImportController);
});

beforeEach(() => {
jest.clearAllMocks();
});

afterAll(async () => {
await AppTestHelper.tearDownTestApp(context);
});
Expand All @@ -75,6 +79,8 @@ describe("Import Controller", () => {

const expectedLog: AppLog = {
userId: authInfo.id,
structureId: authInfo.structureId,
role: authInfo.role,
context: expectedLogContextEntree,
action: "IMPORT_USAGERS_FAILED",
};
Expand Down Expand Up @@ -117,6 +123,8 @@ describe("Import Controller", () => {
nombreTotal: 0,
},
userId: authInfo.id,
structureId: authInfo.structureId,
role: authInfo.role,
});
expect(response.status).toBe(HttpStatus.OK);
expect(JSON.parse(response.text)).toEqual({
Expand Down Expand Up @@ -150,6 +158,8 @@ describe("Import Controller", () => {
nombreTotal: 0,
},
userId: authInfo.id,
structureId: authInfo.structureId,
role: authInfo.role,
});
expect(response.status).toBe(HttpStatus.OK);
expect(JSON.parse(response.text)).toEqual({
Expand Down
6 changes: 6 additions & 0 deletions packages/backend/src/usagers/controllers/import/import.controller.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,6 +223,8 @@ export class ImportController {
await this.appLogsService.create<FailedUsagerImportLogContext>({
action: "IMPORT_USAGERS_FAILED",
userId: user.id,
structureId: user.structureId,
role: user.role,
context: {
nombreActifs: extractUsagersNumber(usagersRows),
nombreErreurs: importErrors.length,
Expand Down Expand Up @@ -250,6 +252,8 @@ export class ImportController {
await this.appLogsService.create<SuccessfulUsagerImportLogContext>({
action: "IMPORT_USAGERS_SUCCESS",
userId: user.id,
role: user.role,
structureId: user.structureId,
context: {
nombreActifs: extractUsagersNumber(usagersRows),
nombreTotal: importPreviewRows.length,
Expand Down Expand Up @@ -294,6 +298,8 @@ export class ImportController {
await this.appLogsService.create<SuccessfulUsagerImportLogContext>({
action: "IMPORT_USAGERS_SUCCESS",
userId: user.id,
structureId: user.structureId,
role: user.role,
context: {
nombreActifs: extractUsagersNumber(usagersRows),
nombreTotal: importPreviewRows.length,
Expand Down
Loading