-
Notifications
You must be signed in to change notification settings - Fork 10
feat(mondomifa): upgrading to angular v18 #3850
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An error occurred: ##
Issues Found
1. This PR contains files that exceed the size limit: 'yarn.lock' (3915 lines of changes), which exceeds the limit of 2000. The limit is 2000 lines per file.
Suggestion: Consider refactoring large changes into smaller, more focused modifications. Large file changes are harder to review and understand.
PR Metrics
- Total files changed: 21
- Reviewable files: 21
- Diff size: 4586 lines
- Documentation files: 0
- Largest file change: 3915 lines
- Addition/Deletion ratio: 14.61
This validation helps ensure the bot focuses on PRs where automated review provides the most value. You can adjust these limits in your .revu.yml
configuration file.
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3850 +/- ##
========================================
Coverage 65.93% 65.94%
========================================
Files 971 971
Lines 16256 16256
Branches 2254 2247 -7
========================================
+ Hits 10719 10720 +1
+ Misses 5349 5192 -157
- Partials 188 344 +156 see 71 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
ReactiveFormsModule, | ||
], | ||
providers: [UsagerAuthService], | ||
providers: [UsagerAuthService, provideHttpClient(withInterceptorsFromDi())], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@hbalty pourquoi cette modification n'est pas aussi faite dans les autres packages ? Je me demande si en montant en v19 la CLI fait pas modifier tous les fichiers qui ont httpclientmodule
809515b
to
98a23ec
Compare
|
🎉 This PR is included in version 2.216.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.