Skip to content

Conversation

hbalty
Copy link
Contributor

@hbalty hbalty commented Aug 11, 2025

No description provided.

@revu-bot revu-bot bot requested a review from revu-bot August 11, 2025 21:56
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occurred: ## ⚠️ PR Review Skipped

Issues Found

1. This PR contains files that exceed the size limit: 'yarn.lock' (3915 lines of changes), which exceeds the limit of 2000. The limit is 2000 lines per file.

Suggestion: Consider refactoring large changes into smaller, more focused modifications. Large file changes are harder to review and understand.

PR Metrics

  • Total files changed: 21
  • Reviewable files: 21
  • Diff size: 4586 lines
  • Documentation files: 0
  • Largest file change: 3915 lines
  • Addition/Deletion ratio: 14.61

This validation helps ensure the bot focuses on PRs where automated review provides the most value. You can adjust these limits in your .revu.yml configuration file.

Revu logs

Copy link

socket-security bot commented Aug 11, 2025

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security
Vulnerability Quality Maintenance License

View full report

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.94%. Comparing base (9e26d7f) to head (7a536b0).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #3850    +/-   ##
========================================
  Coverage   65.93%   65.94%            
========================================
  Files         971      971            
  Lines       16256    16256            
  Branches     2254     2247     -7     
========================================
+ Hits        10719    10720     +1     
+ Misses       5349     5192   -157     
- Partials      188      344   +156     

see 71 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9e26d7f...7a536b0. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ReactiveFormsModule,
],
providers: [UsagerAuthService],
providers: [UsagerAuthService, provideHttpClient(withInterceptorsFromDi())],
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@hbalty pourquoi cette modification n'est pas aussi faite dans les autres packages ? Je me demande si en montant en v19 la CLI fait pas modifier tous les fichiers qui ont httpclientmodule

@hbalty hbalty temporarily deployed to build-review-auto August 14, 2025 12:49 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 14, 2025 12:49 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 14, 2025 12:49 — with GitHub Actions Inactive
@hbalty hbalty temporarily deployed to build-review-auto August 14, 2025 12:49 — with GitHub Actions Inactive
@pYassine pYassine force-pushed the feat-migrating-mon-domifa branch from 809515b to 98a23ec Compare August 14, 2025 22:35
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 22:35 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 22:35 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 22:35 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 22:35 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 22:42 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 22:42 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 22:42 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 22:42 — with GitHub Actions Inactive
Copy link

@tokenbureau
Copy link

tokenbureau bot commented Aug 14, 2025

🎉 Deployment for commit 7a536b0 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-7a536b0c6129001983c67aa7fc3f129155f7181d
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-7a536b0c6129001983c67aa7fc3f129155f7181d
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-7a536b0c6129001983c67aa7fc3f129155f7181d
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-7a536b0c6129001983c67aa7fc3f129155f7181d
Debug

@pYassine pYassine merged commit c1fc7c3 into master Aug 14, 2025
19 checks passed
@pYassine pYassine deleted the feat-migrating-mon-domifa branch August 14, 2025 23:09
@tokenbureau
Copy link

tokenbureau bot commented Aug 14, 2025

🎉 This PR is included in version 2.216.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tokenbureau tokenbureau bot added the released label Aug 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants