feat(structures): making sms day mandatory

[hbalty]

No description provided.

[revu-bot]

This PR implements mandatory SMS day selection by adding validation and UI changes. The implementation correctly adds both client-side validation and user feedback, but has a critical typo in the error message that needs fixing. The validation logic is sound and properly handles both the "at least one day" and "maximum two days" requirements.

[codecov-commenter]

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 12.90323% with 27 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.69%. Comparing base (52b70a6) to head (6679f04).
⚠️ Report is 17 commits behind head on master.

Files with missing lines	Patch %	Lines
.../src/_migrations/1755033531923-manual-migration.ts	20.00%	16 Missing ⚠️
...ructures-sms-form/structures-sms-form.component.ts	0.00%	8 Missing ⚠️
...es/structures/controllers/structures.controller.ts	0.00%	2 Missing ⚠️
...abase/entities/structure/StructureTable.typeorm.ts	0.00%	1 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3852      +/-   ##
==========================================
- Coverage   65.78%   65.69%   -0.10%     
==========================================
  Files         970      971       +1     
  Lines       16220    16249      +29     
  Branches     2237     2251      +14     
==========================================
+ Hits        10671    10674       +3     
- Misses       5208     5528     +320     
+ Partials      341       47     -294     

Files with missing lines	Coverage Δ
...backend/src/modules/structures/dto/schedule.dto.ts	100.00% <ø> (ø)
...es/structures/services/structureCreator.service.ts	82.45% <ø> (-8.78%)	⬇️
...ctures-sms-form/structures-sms-form.component.html	100.00% <ø> (ø)
...abase/entities/structure/StructureTable.typeorm.ts	92.00% <0.00%> (ø)
...es/structures/controllers/structures.controller.ts	39.50% <0.00%> (-1.01%)	⬇️
...ructures-sms-form/structures-sms-form.component.ts	31.57% <0.00%> (-3.21%)	⬇️
.../src/_migrations/1755033531923-manual-migration.ts	20.00% <20.00%> (ø)

... and 129 files with indirect coverage changes

---

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 52b70a6...6679f04. Read the comment docs.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[revu-bot]

An error occurred: Error processing line comments: [
{
"expected": "array",
"code": "invalid_type",
"path": [
"comments"
],
"message": "Invalid input: expected array, received string"
}
]

Revu logs

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[tokenbureau]

🎉 Deployment for commit 6679f04 :

Ingresses

• 🚀 https://admin-domifa-feat-making-sms-day-selection-mandatory.ovh.fabrique.social.gouv.fr/
• 🚀 https://api-domifa-feat-making-sms-day-selection-mandatory.ovh.fabrique.social.gouv.fr/
• 🚀 https://api-domifa-feat-making-sms-day-selection-mandatory.ovh.fabrique.social.gouv.fr/admin/structures/export
• 🚀 https://api-domifa-feat-making-sms-day-selection-mandatory.ovh.fabrique.social.gouv.fr/export
• 🚀 https://api-domifa-feat-making-sms-day-selection-mandatory.ovh.fabrique.social.gouv.fr/stats
• 🚀 https://api-domifa-feat-making-sms-day-selection-mandatory.ovh.fabrique.social.gouv.fr/stats/home
• 🚀 https://domifa-feat-making-sms-day-selection-mandatory.ovh.fabrique.social.gouv.fr/
• 🚀 https://mon-domifa-feat-making-sms-day-selection-mandatory.ovh.fabrique.social.gouv.fr/

Docker images

• 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-6679f0430c75addfc9fcb9ef225c1e8cecea4fef
• 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-6679f0430c75addfc9fcb9ef225c1e8cecea4fef
• 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-6679f0430c75addfc9fcb9ef225c1e8cecea4fef
• 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-6679f0430c75addfc9fcb9ef225c1e8cecea4fef

Debug

• 📕 Loki logs for namespace domifa-feat-making-sms-day-selection-mandatory
• 📈 Pods monitoring for namespace domifa-feat-making-sms-day-selection-mandatory
• 📈 Workloads monitoring for namespace domifa-feat-making-sms-day-selection-mandatory
• 🐘 CNPG pg

[tokenbureau]

🎉 This PR is included in version 2.215.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀