Skip to content

Conversation

pYassine
Copy link
Contributor

No description provided.

@revu-bot revu-bot bot requested a review from revu-bot August 12, 2025 14:38
@pYassine pYassine force-pushed the fix-reorganize-services-manage branch from 9676849 to a048a13 Compare August 13, 2025 19:02
@pYassine pYassine temporarily deployed to build-review-auto August 13, 2025 19:02 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 13, 2025 19:02 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 13, 2025 19:02 — with GitHub Actions Inactive
@pYassine pYassine force-pushed the fix-reorganize-services-manage branch from a048a13 to 2c08e05 Compare August 13, 2025 19:12
@pYassine pYassine temporarily deployed to build-review-auto August 13, 2025 19:12 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 13, 2025 19:12 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 13, 2025 19:12 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 13, 2025 19:12 — with GitHub Actions Inactive
@pYassine pYassine force-pushed the fix-reorganize-services-manage branch from 2c08e05 to e181ce3 Compare August 13, 2025 19:35
@pYassine pYassine temporarily deployed to build-review-auto August 13, 2025 19:35 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 13, 2025 19:35 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 13, 2025 19:35 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 13, 2025 19:35 — with GitHub Actions Inactive
@pYassine pYassine marked this pull request as ready for review August 13, 2025 19:36
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occurred: ## ⚠️ PR Review Skipped

Issues Found

1. This PR changes 32 files, which exceeds the limit of 25 files.

Suggestion: Consider breaking this PR into smaller, more focused changes. Large PRs are harder to review effectively and may contain unrelated changes.

PR Metrics

  • Total files changed: 32
  • Reviewable files: 32
  • Diff size: 623 lines
  • Documentation files: 0
  • Largest file change: 155 lines
  • Addition/Deletion ratio: 3.82

This validation helps ensure the bot focuses on PRs where automated review provides the most value. You can adjust these limits in your .revu.yml configuration file.

Revu logs

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
39.7% Duplication on New Code (required ≤ 15%)

See analysis details on SonarQube Cloud

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 72.46377% with 19 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.76%. Comparing base (79b5b51) to head (e181ce3).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...rs/services/usager-filter/usagersFilter.service.ts 68.33% 19 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3853      +/-   ##
==========================================
- Coverage   65.77%   65.76%   -0.02%     
==========================================
  Files         971      970       -1     
  Lines       16227    16220       -7     
  Branches     2237     2240       +3     
==========================================
- Hits        10674    10667       -7     
- Misses       5210     5506     +296     
+ Partials      343       47     -296     
Files with missing lines Coverage Δ
...es/manage-usagers/classes/UsagersFilterCriteria.ts 95.00% <ø> (ø)
...nd/src/app/modules/manage-usagers/classes/index.ts 100.00% <100.00%> (ø)
...ponents/manage-filters/manage-filters.component.ts 94.44% <ø> (ø)
...nage-usagers-page/manage-usagers-page.component.ts 23.93% <100.00%> (ø)
...ge-usagers-table/manage-usagers-table.component.ts 38.14% <ø> (ø)
...manage-usagers/constants/USAGER_DEADLINES.const.ts 100.00% <ø> (ø)
...pp/modules/manage-usagers/pipes/sort-label.pipe.ts 58.33% <ø> (ø)
.../manage-usagers/services/manage-usagers.service.ts 28.57% <ø> (ø)
...er-filter/calculateUsagersCountByStatus.service.ts 9.09% <ø> (ø)
...e-usagers/services/usager-filter/checkers/index.ts 100.00% <ø> (ø)
... and 10 more

... and 128 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 79b5b51...e181ce3. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tokenbureau
Copy link

tokenbureau bot commented Aug 13, 2025

🎉 Deployment for commit e181ce3 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-e181ce3fce95c760b7d2e920642349495aa3f4f3
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-e181ce3fce95c760b7d2e920642349495aa3f4f3
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-e181ce3fce95c760b7d2e920642349495aa3f4f3
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-e181ce3fce95c760b7d2e920642349495aa3f4f3
Debug

@pYassine pYassine merged commit 536511d into master Aug 13, 2025
18 of 19 checks passed
@pYassine pYassine deleted the fix-reorganize-services-manage branch August 13, 2025 20:00
@tokenbureau
Copy link

tokenbureau bot commented Aug 13, 2025

🎉 This PR is included in version 2.214.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tokenbureau tokenbureau bot added the released label Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants