Skip to content

Conversation

pYassine
Copy link
Contributor

No description provided.

@revu-bot revu-bot bot requested a review from revu-bot August 13, 2025 19:00
@pYassine pYassine force-pushed the fix-reorganize-services-manage branch from 9676849 to a048a13 Compare August 13, 2025 19:02
@pYassine pYassine force-pushed the fix-reorganize-services-manage branch 2 times, most recently from 2c08e05 to e181ce3 Compare August 13, 2025 19:35
Base automatically changed from fix-reorganize-services-manage to master August 13, 2025 20:00
@pYassine pYassine force-pushed the feat-generate-all-mon-domifa branch from 4305389 to 23b617d Compare August 13, 2025 20:15
@pYassine pYassine temporarily deployed to build-review-auto August 13, 2025 20:15 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 13, 2025 20:15 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 13, 2025 20:15 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 13, 2025 20:15 — with GitHub Actions Inactive
@pYassine pYassine marked this pull request as ready for review August 14, 2025 00:23
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occurred: ## ⚠️ PR Review Skipped

Issues Found

1. This PR changes 42 files, which exceeds the limit of 25 files.

Suggestion: Consider breaking this PR into smaller, more focused changes. Large PRs are harder to review effectively and may contain unrelated changes.

PR Metrics

  • Total files changed: 42
  • Reviewable files: 42
  • Diff size: 1743 lines
  • Documentation files: 0
  • Largest file change: 299 lines
  • Addition/Deletion ratio: 5.99

This validation helps ensure the bot focuses on PRs where automated review provides the most value. You can adjust these limits in your .revu.yml configuration file.

Revu logs

@pYassine pYassine force-pushed the feat-generate-all-mon-domifa branch from 23b617d to 62e3547 Compare August 14, 2025 01:02
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 01:02 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 01:02 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 01:02 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 01:02 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 12:43 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 12:43 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 12:43 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 12:43 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Aug 14, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 24.20382% with 238 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.14%. Comparing base (39fdf9c) to head (003b147).
⚠️ Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...nd/src/_migrations/1755523274896-auto-migration.ts 4.41% 64 Missing and 1 partial ⚠️
...gers-manager/portail-usagers-manager.controller.ts 15.38% 54 Missing and 1 partial ⚠️
...manage-user-usager/manage-user-usager.component.ts 41.55% 45 Missing ⚠️
...nd/src/_migrations/1755523274895-auto-migration.ts 8.69% 21 Missing ⚠️
...tabase/services/usager/usagerRepository.service.ts 0.00% 13 Missing ⚠️
...il-usagers/services/user-usager-creator.service.ts 9.09% 10 Missing ⚠️
...nd/src/_migrations/1755523274894-auto-migration.ts 25.00% 8 Missing and 1 partial ⚠️
...rvices/user-usager/userUsagerRepository.service.ts 10.00% 7 Missing and 2 partials ⚠️
...usagers/services/manage-portail-usagers.service.ts 41.66% 7 Missing ⚠️
...c/usagers/controllers/search-usagers.controller.ts 33.33% 2 Missing ⚠️
... and 1 more
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3854      +/-   ##
==========================================
- Coverage   65.93%   65.14%   -0.80%     
==========================================
  Files         971      975       +4     
  Lines       16256    16518     +262     
  Branches     2247     2295      +48     
==========================================
+ Hits        10719    10761      +42     
- Misses       5191     5408     +217     
- Partials      346      349       +3     
Files with missing lines Coverage Δ
...rc/_tests/_core/constants/TEST_USER_USAGER.mock.ts 100.00% <ø> (ø)
...se/entities/user-usager/UserUsagerTable.typeorm.ts 100.00% <100.00%> (ø)
...pen-data-places/update-open-data-places.service.ts 81.81% <ø> (+4.89%) ⬆️
...-usagers-login/portail-usagers-login.controller.ts 83.33% <100.00%> (ø)
...kend/src/modules/portail-usagers/services/index.ts 100.00% <ø> (ø)
...es/user-usager-login-password-generator.service.ts 96.55% <100.00%> (+0.25%) ⬆️
...urity/userUsagerSecurityPasswordChecker.service.ts 91.30% <ø> (+3.30%) ⬆️
...ers-menu/admin-portail-usagers-menu.component.html 100.00% <ø> (ø)
...agers-menu/admin-portail-usagers-menu.component.ts 100.00% <100.00%> (ø)
...nage-user-usager/manage-user-usager.component.html 100.00% <100.00%> (ø)
... and 18 more

... and 5 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 76a1743...003b147. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pYassine pYassine requested a review from hbalty August 14, 2025 21:52
@pYassine pYassine force-pushed the feat-generate-all-mon-domifa branch from 67f755e to e7cdbcf Compare August 14, 2025 22:29
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 22:29 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 14, 2025 22:29 — with GitHub Actions Inactive
@pYassine pYassine force-pushed the feat-generate-all-mon-domifa branch from 32ba763 to 5587463 Compare August 18, 2025 23:41
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 23:41 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 23:41 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 23:41 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 23:49 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 23:49 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 23:49 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 23:53 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 23:53 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 23:53 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 18, 2025 23:53 — with GitHub Actions Inactive
Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
3 Security Hotspots

See analysis details on SonarQube Cloud

@tokenbureau
Copy link

tokenbureau bot commented Aug 19, 2025

🎉 Deployment for commit 003b147 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-003b147dfbf52d4ff93e07a4fa1731bc47449195
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-003b147dfbf52d4ff93e07a4fa1731bc47449195
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-003b147dfbf52d4ff93e07a4fa1731bc47449195
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-003b147dfbf52d4ff93e07a4fa1731bc47449195
Debug

@pYassine pYassine merged commit 4179aee into master Aug 19, 2025
18 of 19 checks passed
@pYassine pYassine deleted the feat-generate-all-mon-domifa branch August 19, 2025 12:34
@tokenbureau
Copy link

tokenbureau bot commented Aug 19, 2025

🎉 This PR is included in version 2.219.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tokenbureau tokenbureau bot added the released label Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants