Skip to content

Conversation

pYassine
Copy link
Contributor

No description provided.

@revu-bot revu-bot bot requested a review from revu-bot August 19, 2025 13:08
@pYassine pYassine marked this pull request as ready for review August 19, 2025 13:08
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR adds SMS history pagination functionality and converts pagination interfaces to classes. The implementation is generally solid but has several critical issues: a dangerous database migration logic error that could corrupt data, potential SQL injection vulnerability in the SMS controller, and inconsistent error handling patterns. The frontend pagination implementation is well-structured and follows established patterns.

@codecov-commenter
Copy link

codecov-commenter commented Aug 19, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 52.45902% with 29 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.06%. Comparing base (f992fee) to head (7556185).

Files with missing lines Patch % Lines
...nd/src/_migrations/1755523274895-auto-migration.ts 0.00% 12 Missing ⚠️
packages/backend/src/modules/sms/sms.controller.ts 44.44% 5 Missing ⚠️
...-historique-sms/profil-historique-sms.component.ts 66.66% 4 Missing ⚠️
...nd/src/_migrations/1755523274896-auto-migration.ts 0.00% 2 Missing ⚠️
...rc/modules/interactions/interactions.controller.ts 33.33% 2 Missing ⚠️
...gers-manager/portail-usagers-manager.controller.ts 33.33% 2 Missing ⚠️
...end/src/usagers/dto/pagination/page-options.dto.ts 33.33% 2 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3864      +/-   ##
==========================================
- Coverage   70.65%   65.06%   -5.60%     
==========================================
  Files         581      972     +391     
  Lines        9256    16505    +7249     
  Branches     1433     2295     +862     
==========================================
+ Hits         6540    10739    +4199     
- Misses       2544     5719    +3175     
+ Partials      172       47     -125     
Files with missing lines Coverage Δ
...ules/interactions/services/interactions.service.ts 81.25% <100.00%> (-1.11%) ⬇️
...d/src/modules/sms/sms.controller.security-tests.ts 100.00% <100.00%> (ø)
...src/usagers/controllers/usager-notes.controller.ts 84.12% <100.00%> (+0.25%) ⬆️
...ckages/backend/src/usagers/dto/pagination/index.ts 100.00% <100.00%> (ø)
...manage-user-usager/manage-user-usager.component.ts 41.55% <100.00%> (ø)
...s/base-usager-notes/base-usager-notes.component.ts 72.50% <100.00%> (ø)
...courriers/profil-historique-courriers.component.ts 52.08% <100.00%> (ø)
...rtail/profil-historique-login-portail.component.ts 79.16% <100.00%> (ø)
...istorique-sms/profil-historique-sms.component.html 100.00% <ø> (ø)
...es/usager-profil/services/usager-profil.service.ts 58.33% <100.00%> (ø)
... and 7 more

... and 456 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f992fee...7556185. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Co-authored-by: Revu <dnum.fabrique@sg.social.gouv.fr>
@pYassine pYassine temporarily deployed to build-review-auto August 19, 2025 13:23 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 19, 2025 13:23 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 19, 2025 13:23 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 19, 2025 13:23 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 19, 2025 17:32 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 19, 2025 17:32 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 19, 2025 17:32 — with GitHub Actions Inactive
@pYassine pYassine temporarily deployed to build-review-auto August 19, 2025 17:32 — with GitHub Actions Inactive
Copy link

Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An error occurred: ## ⚠️ PR Review Skipped

Issues Found

1. This PR changes 29 files, which exceeds the limit of 25 files.

Suggestion: Consider breaking this PR into smaller, more focused changes. Large PRs are harder to review effectively and may contain unrelated changes.

PR Metrics

  • Total files changed: 29
  • Reviewable files: 29
  • Diff size: 1016 lines
  • Documentation files: 0
  • Largest file change: 145 lines
  • Addition/Deletion ratio: 1.06

This validation helps ensure the bot focuses on PRs where automated review provides the most value. You can adjust these limits in your .revu.yml configuration file.

Revu logs

@pYassine pYassine requested a review from hbalty August 19, 2025 17:41
@tokenbureau
Copy link

tokenbureau bot commented Aug 19, 2025

🎉 Deployment for commit 7556185 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-7556185299d489f6a2a011da571b5ed9d03307ea
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-7556185299d489f6a2a011da571b5ed9d03307ea
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-7556185299d489f6a2a011da571b5ed9d03307ea
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-7556185299d489f6a2a011da571b5ed9d03307ea
Debug

@pYassine pYassine merged commit 5e19cea into master Aug 19, 2025
19 checks passed
@pYassine pYassine deleted the feat-add-pagination-sms branch August 19, 2025 21:18
@tokenbureau
Copy link

tokenbureau bot commented Aug 19, 2025

🎉 This PR is included in version 2.220.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@tokenbureau tokenbureau bot added the released label Aug 19, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants