-
Notifications
You must be signed in to change notification settings - Fork 10
feat(backend): add sms history and pagination #3864
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR adds SMS history pagination functionality and converts pagination interfaces to classes. The implementation is generally solid but has several critical issues: a dangerous database migration logic error that could corrupt data, potential SQL injection vulnerability in the SMS controller, and inconsistent error handling patterns. The frontend pagination implementation is well-structured and follows established patterns.
packages/backend/src/_migrations/1755523274895-auto-migration.ts
Outdated
Show resolved
Hide resolved
packages/backend/src/_migrations/1755523274895-auto-migration.ts
Outdated
Show resolved
Hide resolved
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #3864 +/- ##
==========================================
- Coverage 70.65% 65.06% -5.60%
==========================================
Files 581 972 +391
Lines 9256 16505 +7249
Branches 1433 2295 +862
==========================================
+ Hits 6540 10739 +4199
- Misses 2544 5719 +3175
+ Partials 172 47 -125
... and 456 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
Co-authored-by: Revu <dnum.fabrique@sg.social.gouv.fr>
|
packages/backend/src/_migrations/1755523274895-auto-migration.ts
Dismissed
Show dismissed
Hide dismissed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
An error occurred: ##
Issues Found
1. This PR changes 29 files, which exceeds the limit of 25 files.
Suggestion: Consider breaking this PR into smaller, more focused changes. Large PRs are harder to review effectively and may contain unrelated changes.
PR Metrics
- Total files changed: 29
- Reviewable files: 29
- Diff size: 1016 lines
- Documentation files: 0
- Largest file change: 145 lines
- Addition/Deletion ratio: 1.06
This validation helps ensure the bot focuses on PRs where automated review provides the most value. You can adjust these limits in your .revu.yml
configuration file.
🎉 This PR is included in version 2.220.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
No description provided.