fix(logs): fixed total count for success and changed events names #3865

hbalty · 2025-08-19T22:15:44Z

No description provided.

revu-bot

This PR fixes logging issues in the import functionality with some important corrections: fixes the total count calculation for successful imports, renames log action types for consistency, and improves test quality by removing mocks. However, there's a critical syntax error in the controller method that needs immediate attention.

packages/backend/src/usagers/controllers/import/import.controller.ts

packages/backend/src/usagers/controllers/import/import.controller.spec.ts

codecov-commenter · 2025-08-19T22:22:07Z

⚠️ Please install the to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

❌ Patch coverage is 20.00000% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 65.91%. Comparing base (49e694b) to head (e24462d).
⚠️ Report is 5 commits behind head on master.

Files with missing lines	Patch %	Lines
.../src/_migrations/1756117243336-manual-migration.ts	20.00%	4 Missing ⚠️
...rc/usagers/controllers/import/import.controller.ts	20.00%	4 Missing ⚠️
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

@@            Coverage Diff             @@
##           master    #3865      +/-   ##
==========================================
- Coverage   65.92%   65.91%   -0.02%     
==========================================
  Files         971      972       +1     
  Lines       16255    16260       +5     
  Branches     2255     2252       -3     
==========================================
+ Hits        10716    10717       +1     
- Misses       5334     5340       +6     
+ Partials      205      203       -2

Files with missing lines	Coverage Δ
.../modules/general/components/faq/faq.component.html	`100.00% <ø> (ø)`
.../src/_migrations/1756117243336-manual-migration.ts	`20.00% <20.00%> (ø)`
...rc/usagers/controllers/import/import.controller.ts	`87.87% <20.00%> (ø)`

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 49e694b...e24462d. Read the comment docs.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

packages/backend/src/_common/model/app-log/LogAction.type.ts

packages/backend/src/usagers/controllers/import/import.controller.spec.ts

packages/backend/src/usagers/controllers/import/import.controller.ts

sonarqubecloud · 2025-08-25T10:39:15Z

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

tokenbureau · 2025-08-25T10:48:02Z

🎉 Deployment for commit e24462d :

Ingresses

Docker images

📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-e24462dd0a15d2be78b00ec1c25ac387949cc50f
📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-e24462dd0a15d2be78b00ec1c25ac387949cc50f
📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-e24462dd0a15d2be78b00ec1c25ac387949cc50f
📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-e24462dd0a15d2be78b00ec1c25ac387949cc50f

Debug

revu-bot

This PR fixes logging issues by correcting the total count calculation for successful imports and standardizing event naming. The changes improve test quality by replacing mocks with actual database operations and fix a missing user context issue in document download logging. The migration properly handles existing data migration for the renamed events.

revu-bot · 2025-08-25T15:02:25Z

packages/backend/src/usagers/controllers/import/import.controller.spec.ts

+    expect(logs[0].action).toBe("IMPORT_USAGERS_SUCCESS");
+    expect(logs[0].context).toEqual({
+      nombreActifs: 19,
+      nombreTotal: 19,


The updated assertion nombreTotal: 19 correctly reflects the fix where total count now represents processed users rather than all preview rows. This aligns with the controller change that uses usagersRows.length instead of importPreviewRows.length.

revu-bot · 2025-08-25T15:02:26Z

packages/backend/src/_migrations/1756117243336-manual-migration.ts

+
+export class ManualMigration1756117243336 implements MigrationInterface {
+  public async up(queryRunner: QueryRunner): Promise<void> {
+    await queryRunner.query(`


The migration properly handles the event name changes with proper rollback capability. Consider adding a verification query after the update to ensure the migration succeeded and log the number of affected rows for operational visibility.

tokenbureau · 2025-08-25T15:05:31Z

🎉 This PR is included in version 2.220.1 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

revu-bot bot requested a review from revu-bot August 19, 2025 22:15

hbalty marked this pull request as ready for review August 19, 2025 22:15

revu-bot reviewed Aug 19, 2025

View reviewed changes

packages/backend/src/usagers/controllers/import/import.controller.ts Show resolved Hide resolved

revu-bot reviewed Aug 19, 2025

View reviewed changes

packages/backend/src/usagers/controllers/import/import.controller.ts Show resolved Hide resolved

revu-bot reviewed Aug 19, 2025

View reviewed changes

packages/backend/src/usagers/controllers/import/import.controller.spec.ts Show resolved Hide resolved

hbalty temporarily deployed to review-auto August 19, 2025 22:18 — with GitHub Actions Inactive

fix(logs): fixed total count for success and changed events names

824b3d5

hbalty force-pushed the fix-logs-for-import branch from 0a06bc7 to 824b3d5 Compare August 19, 2025 22:31

hbalty temporarily deployed to build-review-auto August 19, 2025 22:32 — with GitHub Actions Inactive

hbalty temporarily deployed to review-auto August 19, 2025 22:33 — with GitHub Actions Inactive

hbalty requested a review from pYassine August 19, 2025 22:35

pYassine reviewed Aug 19, 2025

View reviewed changes

packages/backend/src/_common/model/app-log/LogAction.type.ts Show resolved Hide resolved

pYassine reviewed Aug 19, 2025

View reviewed changes

packages/backend/src/usagers/controllers/import/import.controller.spec.ts Outdated Show resolved Hide resolved

pYassine reviewed Aug 19, 2025

View reviewed changes

packages/backend/src/usagers/controllers/import/import.controller.ts Outdated Show resolved Hide resolved

fix(backend): fix reviews

e24462d

hbalty temporarily deployed to build-review-auto August 25, 2025 10:38 — with GitHub Actions Inactive

hbalty temporarily deployed to review-auto August 25, 2025 10:40 — with GitHub Actions Inactive

pYassine requested a review from revu-bot August 25, 2025 15:01

revu-bot reviewed Aug 25, 2025

View reviewed changes

pYassine merged commit d49cb49 into master Aug 25, 2025
19 checks passed

pYassine deleted the fix-logs-for-import branch August 25, 2025 15:04

tokenbureau bot added the released label Aug 25, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

fix(logs): fixed total count for success and changed events names #3865

fix(logs): fixed total count for success and changed events names #3865

Uh oh!

hbalty commented Aug 19, 2025

Uh oh!

revu-bot left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Aug 19, 2025 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Aug 25, 2025

Uh oh!

tokenbureau bot commented Aug 25, 2025

Uh oh!

revu-bot left a comment

Uh oh!

revu-bot Aug 25, 2025

Uh oh!

revu-bot Aug 25, 2025

Uh oh!

Uh oh!

tokenbureau bot commented Aug 25, 2025

Uh oh!

Uh oh!

fix(logs): fixed total count for success and changed events names #3865

fix(logs): fixed total count for success and changed events names #3865

Uh oh!

Conversation

hbalty commented Aug 19, 2025

Uh oh!

revu-bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

codecov-commenter commented Aug 19, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Uh oh!

Uh oh!

Uh oh!

sonarqubecloud bot commented Aug 25, 2025

Quality Gate passed

Uh oh!

tokenbureau bot commented Aug 25, 2025

Uh oh!

revu-bot left a comment

Choose a reason for hiding this comment

Uh oh!

revu-bot Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

revu-bot Aug 25, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

tokenbureau bot commented Aug 25, 2025

Uh oh!

Uh oh!

codecov-commenter commented Aug 19, 2025 •

edited

Loading