-
Notifications
You must be signed in to change notification settings - Fork 10
Update politique.component.html #3884
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This PR updates contact information and ministry name in the privacy policy. While the ministry name update appears correct, the contact method change from email to URL creates a potential UX and legal compliance issue that should be addressed.
Vous pouvez exercer ces droits en écrivant à | ||
<strong>dpd-minsociaux [at] sg.social.gouv.fr</strong> | ||
<strong>https://domifa.fabrique.social.gouv.fr/contact</strong> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changing from an email address to a URL creates a UX inconsistency. The French text says 'en écrivant à' (by writing to), which implies direct email contact, but now directs users to a web form. This could confuse users who expect to copy-paste an email address. Consider either: 1) Keeping the email format for direct contact, 2) Updating the French text to match the web form approach (e.g., 'via le formulaire de contact'), or 3) Providing both options.
Vous pouvez exercer ces droits en écrivant à | |
<strong>dpd-minsociaux [at] sg.social.gouv.fr</strong> | |
<strong>https://domifa.fabrique.social.gouv.fr/contact</strong> | |
Vous pouvez exercer ces droits via le formulaire de contact : | |
<strong>https://domifa.fabrique.social.gouv.fr/contact</strong> |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #3884 +/- ##
========================================
Coverage 65.12% 65.12%
========================================
Files 976 976
Lines 16577 16577
Branches 2307 2310 +3
========================================
+ Hits 10795 10796 +1
- Misses 5431 5734 +303
+ Partials 351 47 -304
... and 133 files with indirect coverage changes Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
MAJ adresse email de contact et nom du ministère