Skip to content

Conversation

Lycia-r
Copy link
Contributor

@Lycia-r Lycia-r commented Sep 5, 2025

MAJ adresse email de contact et nom du ministère

@revu-bot revu-bot bot requested a review from revu-bot September 5, 2025 14:58
@Lycia-r Lycia-r requested review from pYassine and removed request for revu-bot September 5, 2025 14:58
Copy link
Collaborator

@revu-bot revu-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR updates contact information and ministry name in the privacy policy. While the ministry name update appears correct, the contact method change from email to URL creates a potential UX and legal compliance issue that should be addressed.

Comment on lines 109 to +110
Vous pouvez exercer ces droits en écrivant à
<strong>dpd-minsociaux [at] sg.social.gouv.fr</strong>
<strong>https://domifa.fabrique.social.gouv.fr/contact</strong>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changing from an email address to a URL creates a UX inconsistency. The French text says 'en écrivant à' (by writing to), which implies direct email contact, but now directs users to a web form. This could confuse users who expect to copy-paste an email address. Consider either: 1) Keeping the email format for direct contact, 2) Updating the French text to match the web form approach (e.g., 'via le formulaire de contact'), or 3) Providing both options.

Suggested change
Vous pouvez exercer ces droits en écrivant à
<strong>dpd-minsociaux [at] sg.social.gouv.fr</strong>
<strong>https://domifa.fabrique.social.gouv.fr/contact</strong>
Vous pouvez exercer ces droits via le formulaire de contact :
<strong>https://domifa.fabrique.social.gouv.fr/contact</strong>

Copy link

sonarqubecloud bot commented Sep 5, 2025

@codecov-commenter
Copy link

codecov-commenter commented Sep 5, 2025

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 65.12%. Comparing base (7e5e571) to head (92a4327).
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           master    #3884    +/-   ##
========================================
  Coverage   65.12%   65.12%            
========================================
  Files         976      976            
  Lines       16577    16577            
  Branches     2307     2310     +3     
========================================
+ Hits        10795    10796     +1     
- Misses       5431     5734   +303     
+ Partials      351       47   -304     
Files with missing lines Coverage Δ
...ts/static-pages/politique/politique.component.html 100.00% <ø> (ø)

... and 133 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7e5e571...92a4327. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@tokenbureau
Copy link

tokenbureau bot commented Sep 5, 2025

🎉 Deployment for commit 92a4327 :

Ingresses
Docker images
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/backend:sha-92a4327b4935705b6d129b7559e1870de9a9430d
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/frontend:sha-92a4327b4935705b6d129b7559e1870de9a9430d
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-admins:sha-92a4327b4935705b6d129b7559e1870de9a9430d
  • 📦 docker pull harbor.fabrique.social.gouv.fr/domifa/domifa/portail-usagers:sha-92a4327b4935705b6d129b7559e1870de9a9430d
Debug

@pYassine pYassine closed this Sep 17, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants